Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added messaging support for user accounts [#647] #652

Merged
merged 1 commit into from Mar 16, 2021
Merged

Added messaging support for user accounts [#647] #652

merged 1 commit into from Mar 16, 2021

Conversation

mcpierce
Copy link
Contributor

  • Removed all of the old web-based APIs.
  • Modified the existing angular service to use STOMP messages.
  • Added unit tests to bring all new code to 100% coverage.
  • Removed the error alert on failure to load the current user.

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Added messaging support for user accounts [comixed#647]
fdaadce 
 * Removed all of the old web-based APIs.
 * Modified the existing angular service to use STOMP messages.
 * Added unit tests to bring all new code to 100% coverage.
 * Removed the error alert on failure to load the current user.
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Mar 15, 2021
@mcpierce mcpierce added this to the 0.9 milestone Mar 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.5% 95.5% Coverage
0.0% 0.0% Duplication

@BRUCELLA2 BRUCELLA2 merged commit 2cfbfd7 into comixed:develop Mar 16, 2021
@mcpierce mcpierce deleted the feature/issue-647 branch March 16, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 BRUCELLA2 approved these changes

Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcpierce @BRUCELLA2