Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added loading the comic library via message [#619] #661

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Added loading the comic library via message [#619] #661

merged 1 commit into from
Mar 20, 2021

Conversation

mcpierce
Copy link
Contributor

  • Replaced the old polling mechanism with a messaging topic.
  • Removed the old library update code.

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Mar 20, 2021
@mcpierce mcpierce added this to the 0.9 milestone Mar 20, 2021
@mcpierce
Added loading the comic library via message [comixed#619]
64cc1ff 
 * Replaced the old polling mechanism with a messaging topic.
 * Removed the old library update code.
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2021 •
edited

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.9% 70.9% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit 837c497 into comixed:develop Mar 20, 2021
@mcpierce mcpierce deleted the feature/issue-619 branch March 20, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcpierce