Changed the initial comic format load to a request/response [#642] #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpierce
added
the
enhancement
BRUCELLA2
approved these changes
Mar 21, 2021
BRUCELLA2
suggested changes
Mar 21, 2021
| @@ -35,20 +39,19 @@ | |||
| @RestController | |||
| @Log4j2 | |||
| public class ComicFormatController { | |||
| private static final String LOAD_COMIC_FORMATS = "load.comic-formats"; | |||
| private static final String ADD_COMIC_FORMAT_QUEUE = "/queue/comic-format.add"; | |||
|
|
|||
| @Autowired private ComicFormatService comicFormatService; | |||
| @Autowired private SimpMessagingTemplate messagingTemplate; | |||
|
|
|||
| /** Retrieves the list of all comic formats and publishes them. */ | |||
| @MessageMapping(LOAD_COMIC_FORMATS) | |||
There was a problem hiding this comment.
Need to add the LOAD_COMIC_FORMATS constant in Constants interface
There was a problem hiding this comment.
@BRUCELLA2 I missed committing some local changes before pushing the PR. They're up now.
mcpierce
force-pushed
the
feature/issue-642
branch
3 times, most recently
from
ad41f6f
to
c67eb46
Compare
This was referenced Mar 21, 2021
mcpierce
force-pushed
the
feature/issue-642
branch
from
c67eb46
to
7a944f5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
BRUCELLA2
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cuts the overhead of the formats being broadcast to every user.
Status
READY
Does this PR contain migrations?
NO
Before You Submit Your PR: