Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a batch process for marking blocked pages [#982] #983

Merged
merged 1 commit into from Sep 27, 2021
Merged

Added a batch process for marking blocked pages [#982] #983

merged 1 commit into from Sep 27, 2021

Conversation

mcpierce
Copy link
Contributor

  • Added a process to delete pages with a given hash.
  • Added a process to undelete pages with a given hash.
  • Changed package blockedpage => comicpages.
  • Changed module blocked-pages => comic-pages.
  • Changed blocked page list => blocked hash list.
  • Changed the mark feature to be a part of the list feature.

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Added a batch process for marking blocked pages [comixed#982]
a918bf5 
 * Added a process to delete pages with a given hash.
 * Added a process to undelete pages with a given hash.
 * Changed package blockedpage => comicpages.
 * Changed module blocked-pages => comic-pages.
 * Changed blocked page list => blocked hash list.
 * Changed the mark feature to be a part of the list feature.
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Sep 27, 2021
@mcpierce mcpierce added this to the 0.11 milestone Sep 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2021 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.2% 92.2% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit 68c8215 into comixed:master Sep 27, 2021
@mcpierce mcpierce deleted the feature/issue-982 branch September 27, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcpierce