fix to catch error when it retrieves polymorphic association

closes #113
comma-csv · Apr 30, 2019 · 85b70e1 · 85b70e1
1 parent 8db2aa5
commit 85b70e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/comma/header_extractor.rb b/lib/comma/header_extractor.rb
@@ -45,7 +45,8 @@ def get_association_class(model_class, association)
 
       begin
         model_class.reflect_on_association(association)&.klass
-      rescue NameError
+      rescue ArgumentError, NameError
+        # Since Rails 5.2, ArgumentError is raised.
         nil
       end
     end

diff --git a/spec/comma/rails/active_record_spec.rb b/spec/comma/rails/active_record_spec.rb
@@ -144,8 +144,7 @@ def name
 
     describe 'github pull-request 83' do
       it 'should not raise NameError' do
-        expect { Picture.all.to_comma(:pr_83) }
-          .not_to raise_exception(NameError)
+        expect { Picture.all.to_comma(:pr_83) }.not_to raise_error
       end
     end
   end