Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use timestamp with time zone for timestamp fields in projection_versions #20

Open
datafoo opened this issue Jan 25, 2019 · 2 comments · May be fixed by #23
Open

Use timestamp with time zone for timestamp fields in projection_versions #20

datafoo opened this issue Jan 25, 2019 · 2 comments · May be fixed by #23

Comments

@datafoo
Copy link
Contributor

datafoo commented Jan 25, 2019

The timestamps inserted_at and updated_at in projection_versions table use the PostgreSQL type timestamp without time zone.

Since inserted_at and updated_at are to be implicitly interpreted as UTC, why not making it explicit and use the PostgreSQL type timestamp with time zone instead?
@slashdotdash
Copy link
Member

I'm unsure why I chose to use timestamp without timezone for these fields, possibly because I thought NaiveDateTime was more appropriate than DateTime.

Am happy to accept a pull request to change these.

@datafoo
Copy link
Contributor Author

datafoo commented Jan 25, 2019

I may work on this pull request.

datafoo added a commit to datafoo/commanded-ecto-projections that referenced this issue Feb 5, 2019
@datafoo
Use timestamp with time zone for timestamp fields in `projection_ve…
6037c58 
…rsions`.

Fixes commanded#20.
@datafoo datafoo linked a pull request Feb 5, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@slashdotdash @datafoo