Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise loglevel of wrong expected version #10

Merged
merged 1 commit into from Mar 13, 2018

Conversation

timbuchwaldt
Copy link
Contributor

@timbuchwaldt timbuchwaldt commented Mar 13, 2018

As this might well stall a system the log level should be higher.

We have seen this issue kill our Commanded system completely as no new events were appended until we completely removed the stream from EventStore and restarted our application

As this might well stall a system the log level should be higher.
@slashdotdash
Copy link
Member

slashdotdash commented Mar 13, 2018

@timbuchwaldt The latest Commanded version (master branch and recently published to Hex as v0.16.0-rc.0) includes a change (#132) to handle {:error, :wrong_expected_version} response when persisting events.

It now attempts to rebuild the aggregate state from the missing events and try to execute the command again. This will be retried up to ten times before an error is returned to command dispatch. Hopefully that should prevent the scenario from causing you an issue.

I've merged you pull request. It will be included in the next release published to Hex (v0.5.0).

@slashdotdash slashdotdash merged commit af0b46a into commanded:master Mar 13, 2018
slashdotdash added a commit that referenced this pull request Mar 13, 2018
@timbuchwaldt
Copy link
Contributor Author

Hey @slashdotdash - I saw, just working on integrating a git build to try that out, issue coming up regarding the current master state in a sec :P

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants