Supervisor for Subscription processes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 23, 2018 17:42
SubscriptionsSupervisor is responsible for keeping track of the currently started Subscriptions. This removes the need for manual bookkeeping in Commanded.EventStore.Adapters.Extreme. Additional code will be removed after this.
Commanded.EventStore.Adapters.Extreme no longer needs to be stateful, therefore it no longer needs to be a GenServer.
|
Not sure what it's about the CI that is causing issues over there, the tests are all green on my machine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
SubscriptionsSupervisor, which is responsible for keeping track of the currently started Subscriptions.This removes the need for manual bookkeeping in
Commanded.EventStore.Adapters.Extremeand we can port it from a GenServer to a plain module.This fixes an issue where
Commanded.EventStore.Adapters.Extremecould crash and forget about the subscriptions that were already started, which could cause duplicate Subscription-processes to be started, until the maximum subscriber count of EventStore is reached.Please feel free to make any adjustments :-)