Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression introduced in the logger #294

Closed
datafoo opened this issue Jul 16, 2019 · 2 comments · Fixed by #295
Closed

Regression introduced in the logger #294

datafoo opened this issue Jul 16, 2019 · 2 comments · Fixed by #295

Comments

@datafoo
Copy link
Contributor

datafoo commented Jul 16, 2019

I introduced a regression in the logger in Commanded.Middleware.Logger.delta/1:
deb15cf#diff-858f93ba6e33b9c3a7db0521dc3c8b45

The logger displays negative durations which does not make sense, my apologies.
@Freyskeyd
Copy link
Collaborator

Hello,

Thank's for reporting the issue. Feel free to open a Pull Request at any time 😄

@datafoo
Copy link
Contributor Author

datafoo commented Jul 16, 2019

Of course, I am working on it.

datafoo added a commit to datafoo/commanded that referenced this issue Jul 16, 2019
@datafoo
Fix bug with Commanded.Middleware.Logger.delta/1.
6639e20 
Fixes commanded#294
@datafoo datafoo mentioned this issue Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression in Commanded.Middleware.Logger.delta/1. datafoo/commanded
2 participants
@Freyskeyd @datafoo