Support opts in append_to_stream #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpieper
reviewed
Oct 26, 2023
| @@ -31,7 +31,8 @@ defmodule Commanded.EventStore.Adapter do | |||
| adapter_meta, | |||
| stream_uuid, | |||
| expected_version, | |||
| events :: list(EventData.t()) | |||
| events :: list(EventData.t()), | |||
| options | |||
There was a problem hiding this comment.
Wouldn't this mean that we would get a warning for every custom adapter that does not implement append_to_stream/5? And additionally warnings for append_to_stream/4 functions using @impl true or @impl Commanded.EventStore.Adapter 🤔
slashdotdash
added a commit
that referenced
this pull request
Jan 9, 2024
slashdotdash
added a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.