Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix elixir warning deprecation message #278

Merged
merged 2 commits into from Oct 18, 2023

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Oct 4, 2023

Signed-off-by: Yordis Prieto yordis.prieto@gmail.com

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis marked this pull request as ready for review October 4, 2023 03:50
Copy link

@ddengler ddengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; just stumbled onto the same issue cleaning up warnings in a project

@slashdotdash
Copy link
Member

Will also need to bump the version of Elixir supported in mix.exs from v1.10 to v1.11 as that is when the Logger.warning/2 function was added.

@yordis
Copy link
Contributor Author

yordis commented Oct 17, 2023

✅ done

@slashdotdash slashdotdash merged commit 281eed3 into commanded:master Oct 18, 2023
2 checks passed
slashdotdash added a commit that referenced this pull request Oct 18, 2023
@yordis yordis deleted the chore-fix-warning branch October 18, 2023 16:15
slashdotdash added a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants