FB_set_pixels crashes when count > 255

[irmen]

FB_set_pixels with a count of 256 or more crashes.
I think it's caused by the jsr that it's doing internally and that it is not properly dealing with the double loop invocation or some thing.

What confuses me is that FB_set_pixels is defined twice:

x16-rom/kernal/drivers/x16/framebuffer.s

Line 176 in a853afd

FB_set_pixels:

and also here

x16-rom/kernal/graph/drv_ram.s

Line 164 in 31a9470

FB_set_pixels:

[greg-king5]

What confuses me is that FB_set_pixels: is defined twice:

x16-rom/kernal/graph/drv_ram.s

Line 6 in 31a9470

; XXX This code is incomplete and not currently included in the build.

Ignore that file.

[greg-king5]

FB_set_pixels with a count of 256 or more crashes.

It's caused by the PopB lines in the inner loop -- that's the wrong place. When the count's high-byte is non-zero, they "eat" the stack! The pseudo-registers must be handled in the same way that FB_get_pixels does it:

x16-rom/kernal/drivers/x16/framebuffer.s

Lines 208 to 214 in 9498437

	FB_get_pixels:
	PushB r0H
	PushB r1H
	jsr get_pixels_FG
	PopB r1H
	PopB r0H
	rts

.

[irmen]

That looks like something I can attempt to make a fix and a PR for later this week or in the weekend perhaps.

edit: fix was made #180