Added ZA public holiday for Voting Day on May 29, 2024

[tristdrum]

This PR introduces an update to the South African holidays list by adding the Voting Day public holiday on May 29, 2024. The addition of this holiday ensures the date-holidays library remains up-to-date with official South African public holidays, reflecting the government's declaration of Voting Day as a public holiday to facilitate participation in the electoral process.

Changes Made:

• Updated data/countries/ZA.yaml by adding an entry for Voting Day on May 29, 2024. This change includes the holiday's official name in English and references to the official government announcements and public holiday declarations.

References:

• Presidency of South Africa Announcement
• Government Gazette on Public Holidays Act

This contribution aligns with the repository's guidelines for updating and adding new holidays. I have verified the accuracy of the information against official sources and ensured the YAML file adheres to the existing format and standards within the repository.

Please review the changes at your convenience, and let me know if any adjustments are needed. Thank you for considering this addition to ensure the library reflects the current public holidays in South Africa.

[tristdrum]

Hello @commenthol,

I hope this message finds you well. I wanted to bring to your attention that, as detailed in my recent comment, I encountered difficulties running the tests locally due to an ongoing issue. This has, unfortunately, prevented me from verifying the changes in my latest PR as thoroughly as I would have liked.

Despite this challenge, I've strived to ensure that the submission reflects both the lessons learned from my initial contribution and the high standards of your project. I deeply appreciate your understanding and support as I navigate these technical hurdles.

Thank you very much for your patience and guidance throughout this process.

Best regards,
@tristdrum

[tristdrum]

Hi @commenthol,

I've noticed the test failures and attempted to address them by adding more tests. However, I'm currently unable to proceed with this approach because I'm facing issues with building the project in the preliminary steps. I sincerely apologize for any inconvenience this may cause and am actively seeking a resolution to contribute effectively.

Thank you for your understanding.

Best,
@tristdrum

[commenthol]

Hi @tristdrum,
The testset requires some updates to incorporate your changes.
You can achieve this by running the steps as described in CONTRIBUTING.md.
Step 8. needs of course

npx mocha test/all.mocha.js --writetests --countries ZA

[tristdrum]

@commenthol thank you for the help!

Should be good to go now! 😁

[tristdrum]

Hi @commenthol, just bumping this to the top of your inbox again.

(no rush major rush as the holiday is in 6 weeks time, just thought I'd follow up to try and get it published before then).

Thank you, and sorry for the burden placed on you. As per my direct email, please lmk how I can help more. This is an awesome repo and would love to give back to the open source community.

[tristdrum]

Thank you @commenthol!