[ua-parser#233] fix for Edge 12

commenthol · Jun 7, 2017 · 57bc006 · 57bc006
1 parent 14e2c8d
commit 57bc006
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/regexes.yaml b/regexes.yaml
@@ -361,7 +361,7 @@ user_agent_parsers:
   - regex: '(Vivaldi)/(\d+)\.(\d+)\.(\d+)'
 
   # Edge/major_version.minor_version
-  - regex: '(Edge)/(\d+)\.(\d+)'
+  - regex: '(Edge)/(\d+)(?:\.(\d+))?'
 
   # Brave Browser https://brave.com/
   - regex: '(brave)/(\d+)\.(\d+)\.(\d+) Chrome'

diff --git a/tests/test_ua.yaml b/tests/test_ua.yaml
@@ -7127,6 +7127,13 @@ test_cases:
 
   - user_agent_string: 'Mozilla/5.0 (compatible; Qwantify/2.4w; +https://www.qwant.com/)/2.4w'
     family: 'Qwantify'
-    major: "2"
-    minor: "4"
+    major: '2'
+    minor: '4'
+    patch:
+
+  - user_agent_string: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12'
+    family: 'Edge'
+    major: '12'
+    minor:
     patch:
+