Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for a page.title to remove ghost items #2

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Add a check for a page.title to remove ghost items #2

merged 1 commit into from
Nov 20, 2017

Conversation

belbiy
Copy link
Collaborator

@belbiy belbiy commented Nov 20, 2017

@belbiy belbiy changed the base branch from master to oms-stable November 20, 2017 16:12
philbernou
philbernou approved these changes Nov 20, 2017
View reviewed changes
Copy link

@philbernou philbernou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That removes the ghosts :)

@belbiy belbiy merged commit 91d229c into oms-stable Nov 20, 2017
@belbiy belbiy deleted the yb-ghost-sidebar-entries branch November 20, 2017 16:36
@belbiy
Copy link
Collaborator Author

belbiy commented Nov 20, 2017

Ok just make sure that all pages have title: ok?

@philbernou
Copy link

got you. Will add a test for the title tag to the deploy pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philbernou philbernou philbernou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@belbiy @philbernou