Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-299] Rebranding theme with latest Spectrum CSS and branding content #74

Merged
merged 57 commits into from
May 20, 2021

Conversation

bdenham
Copy link
Collaborator

@bdenham bdenham commented May 18, 2021

This PR updates all Spectrum CSS packages and adds new ones to the devdocs theme. Many changes were made and much testing has been done to fix the issues created by new Spectrum styling.

I will make another few passes with more staging builds to catch all the obvious CSS abberations. After I'm done, I'll mark it as ready for review.

More soon...

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a bit going on here... Is there a staging build for devdocs that I can look at?

@bdenham
Copy link
Collaborator Author

bdenham commented May 18, 2021

Yes. A lot. And no, not yet. I hope to get one out there later today. I used merchdocs as my testbed for all these changes, fixing CSS aberrations as I went. There are still a few that I will address after I finish the devdocs content changes.

@belbiy
Copy link
Collaborator

belbiy commented May 19, 2021

I think it's better to use quiet buttons on the github links block, these ones look way off, never seen that on other adobe products. I know it's technically allowed, just saying it looks "off" ;-)
Screen Shot 2021-05-18 at 7 56 11 PM

@jeff-matthews
Copy link
Contributor

The version switcher button also looks off:

Screen Shot 2021-05-19 at 7 43 16 AM

And the search bar needs some alignment:

Screen Shot 2021-05-19 at 7 45 02 AM

@bdenham bdenham marked this pull request as ready for review May 20, 2021 14:00
jeff-matthews
jeff-matthews previously approved these changes May 20, 2021
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest devdocs staging build looks good!

https://devdocs.magedevteam.com/261/

@belbiy
Copy link
Collaborator

belbiy commented May 20, 2021

Couple of small bugs:

Github link still look a little bit off:
Screen Shot 2021-05-20 at 11 35 15 AM
You probably need to add a spectrum-ActionButton class to the button itself. Also make sure that you adding spectrum-ActionButton--sizeM (or sizeS) to both button and icon (spectrum-Icon--sizeM). This is a new syntax i think, it makes code more verbose, but also makes buttons look more consistent.

Kind of same thing with the page updated button:
Screen Shot 2021-05-20 at 11 37 22 AM
button needs a size class spectrum-ActionButton--sizeM and icon should have the corresponging spectrum-Icon--sizeM

Other than that, looks great!

@bdenham
Copy link
Collaborator Author

bdenham commented May 20, 2021

Thanks for the sanity check, Eugene! Got em.

jeff-matthews
jeff-matthews previously approved these changes May 20, 2021
@bdenham bdenham merged commit e061b24 into master May 20, 2021
@bdenham bdenham deleted the cleanup branch May 20, 2021 18:52
@dshevtsov dshevtsov mentioned this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants