Doctrine cache #26
Open
Doctrine cache #26
+431
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @throws \InvalidArgumentException | ||
| */ | ||
| public function setCache($cache) |
There was a problem hiding this comment.
This should just use type hinting
|
Hi, I'll let you know once it's ok |
|
Any updates on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here is a proposition of doctrine cache integration for token persistence
i think that doctrine/cache is a thin, efficient and relatively widely used cache layer.
I have added tests, but not sur that they are really efficient.
On cache save, i use the expire data to set cache lifetime, and therefore i have to remove expire value in cached data, do you see use cases where this could be a problem ?
Thanks in advance for you remarks .
Xavier