Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Travis CI for PHP 7.4 #83

Merged
merged 1 commit into from Oct 2, 2020

Conversation

limenet
Copy link
Contributor

@limenet limenet commented Oct 1, 2020

When I submitted #82 , I noticed Travis wasn't testing against PHP 7.4. This PR also lists PHP 7.4 (current stable) as test targets for Travis.

Reason why I created a separate PR is to address potential PHP 7.4 failures separately from the new features in my other PR. I hope that's oaky!

@limenet
Copy link
Contributor Author

limenet commented Oct 1, 2020

Also, it appears your Travis CI integration Github isn't working anymore. Older PRs still show the build status (in the overview page), but newer ones don't, yet builds are still triggered, see e.g. https://travis-ci.org/github/commerceguys/intl/builds/732018484.

@bojanz
Copy link
Contributor

bojanz commented Oct 2, 2020

Looks like travis-ci.org is slowly dying, it's supposed to be turned off at the end of this year. I turned on the .com version but have no clue how to do a full migration yet. An adventure for another day.

@bojanz bojanz merged commit a09d9c3 into commerceguys:master Oct 2, 2020
@bojanz
Copy link
Contributor

bojanz commented Oct 2, 2020

Thanks!

@limenet
Copy link
Contributor Author

limenet commented Oct 3, 2020

@bojanz Yeah, Travis got a bit confusing recently. What worked for my repos was to "install" the Marketplace app. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants