Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop to InputReadonly to toggle hidden values #626

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gciotola
Copy link
Contributor

@gciotola gciotola commented Apr 19, 2024

What I did

  • Added a secret prop to hide value from InputReadonly and also show a button to show/hide input value
  • add focus outline on the input group level to display outline feedback also when buttons are focused

https://deploy-preview-626--commercelayer-app-elements.netlify.app/?path=/docs/forms-ui-inputreadonly--docs#secret

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@gciotola gciotola changed the title fix: add prop to InputReadonly to toggle hidden values Add prop to InputReadonly to toggle hidden values Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit a3d82f1
🔍 Latest deploy log https://app.netlify.com/sites/commercelayer-app-elements/deploys/66224f613b04000009cb3508
😎 Deploy Preview https://deploy-preview-626--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gciotola gciotola self-assigned this Apr 19, 2024
@gciotola gciotola added the enhancement New feature or request label Apr 19, 2024
@gciotola gciotola marked this pull request as ready for review April 19, 2024 11:03
@gciotola gciotola merged commit f681072 into main Apr 22, 2024
6 checks passed
@gciotola gciotola deleted the input-readonly-hide branch April 22, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants