Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useResourceAddressOverlay hook and ResourceAddressFormFields component can be reused in other forms #637

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

marcomontalbano
Copy link
Member

@marcomontalbano marcomontalbano commented Apr 24, 2024

What I did

I exported:

  • useResourceAddressOverlay hook so that the address overlay can be opened from a dropdown.
  • ResourceAddressFormFields component can be reused in other forms

How to test

https://deploy-preview-637--commercelayer-app-elements.netlify.app/?path=/docs/resources-resourceaddress--docs

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@marcomontalbano marcomontalbano added the enhancement New feature or request label Apr 24, 2024
@marcomontalbano marcomontalbano self-assigned this Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit cac86f3
🔍 Latest deploy log https://app.netlify.com/sites/commercelayer-app-elements/deploys/662fefeceff80b0008d96be5
😎 Deploy Preview https://deploy-preview-637--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcomontalbano marcomontalbano changed the title Add 'useResourceAddressOverlay' hook Add useResourceAddressOverlay hook and ResourceAddressFormFields component can be reused in other forms Apr 30, 2024
@marcomontalbano marcomontalbano marked this pull request as ready for review April 30, 2024 09:30
@marcomontalbano marcomontalbano merged commit 51e5681 into main Apr 30, 2024
6 checks passed
@marcomontalbano marcomontalbano deleted the use-resource-address-overlay branch April 30, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants