Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add returns management #1

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Add returns management #1

merged 4 commits into from
Nov 15, 2023

Conversation

pfferrari
Copy link
Contributor

@pfferrari pfferrari commented Oct 5, 2023

What I did

  • Added the returns listing and filtering page

ReturnsList

  • Added the return detail page

ReturnDetail

Once a return is in status `received` it won't show any trigger action. The `Restock` link will be visible if any restockable return_line_item is available.

ReturnReceived

  • Added the restock form

RestockForm

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari added the enhancement New feature or request label Oct 5, 2023
@pfferrari pfferrari self-assigned this Oct 5, 2023
@pfferrari pfferrari marked this pull request as ready for review October 20, 2023 06:51
.npmrc Outdated Show resolved Hide resolved
packages/app/src/hooks/useBackToList.tsx Outdated Show resolved Hide resolved
packages/app/src/hooks/useReturnDetails.tsx Outdated Show resolved Hide resolved
gciotola
gciotola previously approved these changes Oct 20, 2023
@pfferrari
Copy link
Contributor Author

pfferrari commented Nov 3, 2023

@malessani I just updated staging version of returns app with updated app-elements library to provide Restocked on badge for return_line_items. I also added restocked line items in return summary.
I temporarily left on a side only the issue about removing the checkbox selector when a single return line item is selectable in the Restock InputCheckboxGroup.

@malessani
Copy link

For the moment I would avoid to change the InputCheckboxGroup. Let's decide later on this

malessani
malessani previously approved these changes Nov 13, 2023
@pfferrari
Copy link
Contributor Author

pfferrari commented Nov 14, 2023

@malessani I just updated both stg and prd environments of returns app to bring these latest fixes:

  • visibility of destination stock location in list elements
  • Restocked on badge based on updated helper method to have Restocked today in case and with the user timezone
  • Reference visible in detail page only if effectively not empty

@pfferrari pfferrari merged commit f9430ca into main Nov 15, 2023
2 checks passed
@pfferrari pfferrari deleted the feat/add-returns-management branch November 15, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants