Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use return.stock_location as Destination #3

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Use return.stock_location as Destination #3

merged 3 commits into from
Nov 16, 2023

Conversation

pfferrari
Copy link
Contributor

@pfferrari pfferrari commented Nov 15, 2023 •
edited

What I did

  • Updated app-elements package to have ResourceListItem of type return to show stock_location as destination info
  • Updated return detail page to show return.stock_location as Destination
  • Added the market name aside the order number in return detail

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari added the bug Something isn't working label Nov 15, 2023
@pfferrari pfferrari self-assigned this Nov 15, 2023
@pfferrari pfferrari merged commit 787bdd2 into main Nov 16, 2023
2 checks passed
@pfferrari pfferrari deleted the fix-destination-visualization branch November 16, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gciotola gciotola gciotola approved these changes

@marcomontalbano marcomontalbano Awaiting requested review from marcomontalbano

@malessani malessani Awaiting requested review from malessani

Assignees

@pfferrari pfferrari

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pfferrari @gciotola