fix: Types issues

commercelayer · Feb 23, 2022 · df0da67 · df0da67
1 parent 8d2416f
commit df0da67
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 12 deletions.
diff --git a/src/components/AvailabilityContainer.tsx b/src/components/AvailabilityContainer.tsx
@@ -10,7 +10,6 @@ import availabilityReducer, {
   getAvailability,
 } from '#reducers/AvailabilityReducer'
 import AvailabilityContext from '#context/AvailabilityContext'
-import { isEmpty } from 'lodash'
 import ItemContext from '#context/ItemContext'
 import getCurrentItemKey from '#utils/getCurrentItemKey'
 import components from '#config/components'
@@ -48,8 +47,8 @@ const AvailabilityContainer: FunctionComponent<AvailabilityContainerProps> = (
           delivery_lead_times: [],
         },
       ]
-      if (!isEmpty(level) && level?.delivery_lead_times?.length > 0) {
-        const [delivery] = level?.delivery_lead_times
+      if (level !== undefined && level?.delivery_lead_times?.length > 0) {
+        const [delivery] = level.delivery_lead_times
         dispatch({
           type: 'setAvailability',
           payload: { ...delivery, quantity: level?.quantity },

diff --git a/src/components/PaymentSourceBrandIcon.tsx b/src/components/PaymentSourceBrandIcon.tsx
@@ -1,4 +1,4 @@
-import PaymentSourceContext, { iconBrand } from '#context/PaymentSourceContext'
+import PaymentSourceContext, { IconBrand } from '#context/PaymentSourceContext'
 import React, { FunctionComponent, useContext, useRef } from 'react'
 import Parent from './utils/Parent'
 import { FunctionChildren } from '#typings'
@@ -9,7 +9,7 @@ const displayName = components.PaymentSourceBrandIcon.displayName
 
 type CustomComponent = FunctionChildren<
   Omit<
-    Props & { brand: iconBrand; defaultSrc: string; url: string },
+    Props & { brand: IconBrand; defaultSrc: string; url: string },
     'children'
   >
 >

diff --git a/src/components/PaymentSourceBrandName.tsx b/src/components/PaymentSourceBrandName.tsx
@@ -1,4 +1,4 @@
-import PaymentSourceContext, { iconBrand } from '#context/PaymentSourceContext'
+import PaymentSourceContext, { IconBrand } from '#context/PaymentSourceContext'
 import { capitalize } from 'lodash'
 import React, { FunctionComponent, useContext } from 'react'
 import Parent from './utils/Parent'
@@ -9,7 +9,7 @@ const propTypes = components.PaymentSourceBrandName.propTypes
 const displayName = components.PaymentSourceBrandName.displayName
 
 type CustomComponent = FunctionChildren<
-  Omit<Props & { brand: iconBrand }, 'children'>
+  Omit<Props & { brand: IconBrand }, 'children'>
 >
 
 type Props = {

diff --git a/src/components/utils/PaymentCardsTemplate.tsx b/src/components/utils/PaymentCardsTemplate.tsx
@@ -5,7 +5,7 @@ import {
   PaymentResource,
   PaymentSourceType,
 } from '#reducers/PaymentMethodReducer'
-import PaymentSourceContext, { iconBrand } from '#context/PaymentSourceContext'
+import PaymentSourceContext, { IconBrand } from '#context/PaymentSourceContext'
 import { FunctionChildren } from '#typings'
 import getCardDetails from '#utils/getCardDetails'
 
@@ -15,7 +15,7 @@ type ChildrenProps = Pick<Props, 'customerPayments'> & {
 
 type CustomerPayment = PaymentSourceType & {
   card?: {
-    brand?: iconBrand
+    brand?: IconBrand
     last4?: string
   }
   handleClick?: () => void

diff --git a/src/context/OrderContext.ts b/src/context/OrderContext.ts
@@ -20,7 +20,7 @@ import {
 type DefaultContext = {
   createOrder: CreateOrder
   addToCart: AddToCart
-  setOrderErrors: typeof setOrderErrors
+  setOrderErrors: (errors: unknown) => void
   setGiftCardOrCouponCode: SetGiftCardOrCouponCode
   removeGiftCardOrCouponCode: RemoveGiftCardOrCouponCode
   saveAddressToCustomerAddressBook: SaveAddressToCustomerAddressBook
@@ -32,12 +32,14 @@ type DefaultContext = {
 export const defaultOrderContext = {
   addToCart,
   createOrder,
-  setOrderErrors,
+  setOrderErrors: () => {
+    return
+  },
   setGiftCardOrCouponCode,
   removeGiftCardOrCouponCode,
   saveAddressToCustomerAddressBook,
   addResourceToInclude,
-  getOrder: async (_id: string) => {
+  getOrder: async () => {
     return
   },
   updateOrder,