refactor(theme): to make the link underline style configurable via a prop #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/commercetools/commercetools-docs-kit/kfrbxtp3y |
emmenko
commented
Jan 29, 2020
| @@ -39,7 +38,7 @@ const getStyles = props => { | |||
| const BetaFlag = props => { | |||
| if (props.href) { | |||
| return ( | |||
| <Link href={props.href} css={getStyles(props)}> | |||
| <Link href={props.href} noUnderline={true} css={getStyles(props)}> | |||
There was a problem hiding this comment.
FYI: the prop is called noUnderline on purpose, because the default behavior should be with underline and you can decide to explicitly opt-out.
emmenko
force-pushed
the
nm-fix-link-underline-style
branch
from
0f42c5d
to
4fc428e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to avoid having to override styles directly, but instead changing the appearance via a prop.