fix(theme): dynamically render the cookie consent scripts only on *.commercetools.com domain #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/commercetools/commercetools-docs-kit/blda3wmqt |
nkuehn
commented
Apr 7, 2020
nkuehn
commented
Apr 7, 2020
nkuehn
changed the title
emmenko
requested changes
Apr 8, 2020
emmenko
force-pushed
the
nk-brute-force-hide-cookie-annoyance
branch
from
894e019
to
20d23b2
Compare
emmenko
force-pushed
the
nk-brute-force-hide-cookie-annoyance
branch
from
20d23b2
to
1e95c89
Compare
emmenko
reviewed
Apr 8, 2020
Comment on lines
+47
to
+56
| if (window && window.location.host.includes('.commercetools.com')) { | ||
| injectScript( | ||
| 'https://cdn.cookielaw.org/consent/b104027d-4d10-4b75-9675-9ffef11562a8/OtAutoBlock.js' | ||
| ); | ||
| injectScript( | ||
| 'https://cdn.cookielaw.org/scripttemplates/otSDKStub.js', | ||
| { 'data-domain-script': 'b104027d-4d10-4b75-9675-9ffef11562a8' }, | ||
| 'function OptanonWrapper() {};' | ||
| ); | ||
| } |
There was a problem hiding this comment.
This seems to do the trick.
I'd like to try this approach first.
emmenko
changed the title
|
@nkuehn please take a look, I would like to try this approach first. |
|
OK, just merge and approve yourself - we'll have to wait all through production anyways to test. |
|
I'll test the canary release on appkit. |
emmenko
approved these changes
Apr 8, 2020
emmenko
force-pushed
the
nk-brute-force-hide-cookie-annoyance
branch
from
1e95c89
to
ed2b9e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #346
This is the technique that is used on the current docs.commercetools.com site - it's a client side approach that activates a CSS rule that removes the complete thing from the visible DOM, letting it do it's buggy work however it wants as long as it doesn't show up.
The check is on the .commercetools.com domain level because that's the cookie scope the script uses.
The root cause it that the cookie consent script fails on other domains and does not close.