This repository has been archived by the owner on May 24, 2023. It is now read-only.
#62 document the edge cases #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| 1. The user confirms the payment in the first tab | ||
| 1. Paypal has the address of Berlin, but the shop will deliver the goods to Paris. | ||
|
|
||
| **Possible solution:** the backend calls `patch/payments` endpoint every time user changes it. |
There was a problem hiding this comment.
- backend or frontend calls patch?
There was a problem hiding this comment.
Should be backend:
* The frontend - the browser part of the shop. This is what the user interacts with.
* The backend - the shop server.
There was a problem hiding this comment.
yes, but how backend get known the a changes the address? Only front-end could know this and call the patch, isn't it?
README.md
Outdated
| 1. user has cart with item1=10€ | ||
| 1. user is redirected to Paypal payment page | ||
| 1. in a different tab, user changes his cart to e.g. item2=20€ | ||
| 1. user completes the payment in the first tab |
There was a problem hiding this comment.
and redirects back to approval page
There was a problem hiding this comment.
I put the shop instead of approval page. 865ce6b
README.md
Outdated
| 1. user is redirected to Paypal payment page | ||
| 1. in a different tab, user changes his cart to e.g. item2=20€ | ||
| 1. user completes the payment in the first tab | ||
| 1. paypal approves the payment for 10€, but the real total amount has changed to 20€ |
There was a problem hiding this comment.
real total amount of sold (shipped) items
README.md
Outdated
| 1. user completes the payment in the first tab | ||
| 1. paypal approves the payment for 10€, but the real total amount has changed to 20€ | ||
|
|
||
| **Possible solution:** the backend has to compare total amount of the payment and total amount of payment's cart before calling `patch/payments` endpoint. |
There was a problem hiding this comment.
before calling execute?
andrii-kovalenko-ct
approved these changes
Sep 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62