Merge pull request #346 from commercetools/fix-productdatalike

commercetools · Jul 29, 2022 · abd0b2b · abd0b2b
2 parents 26349be + 976aa30
commit abd0b2b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/...ools-sdk-java-api/src/main/java/com/commercetools/api/models/product/ProductDataLike.java b/...ools-sdk-java-api/src/main/java/com/commercetools/api/models/product/ProductDataLike.java
@@ -9,6 +9,7 @@
 import com.commercetools.api.models.common.LocalizedString;
 import com.commercetools.api.models.common.MetaAttributes;
 import com.commercetools.api.models.common.WithLocalizedSlug;
+import com.fasterxml.jackson.annotation.JsonIgnore;
 
 /**
  * Interface to describe commonalities between differen product representations
@@ -60,6 +61,7 @@ public interface ProductDataLike extends WithLocalizedSlug, MetaAttributes {
      * @see #getVariants()
      * @return all variants
      */
+    @JsonIgnore
     default List<ProductVariant> getAllVariants() {
         return ProductsPackage.getAllVariants(this);
     }

diff --git a/commercetools/commercetools-sdk-java-api/src/test/java/com/commercetools/ProductTest.java b/commercetools/commercetools-sdk-java-api/src/test/java/com/commercetools/ProductTest.java
@@ -6,11 +6,11 @@
 import java.util.stream.Collectors;
 
 import com.commercetools.api.models.common.LocalizedStringBuilder;
-import com.commercetools.api.models.product.ProductDraft;
-import com.commercetools.api.models.product.ProductDraftBuilder;
-import com.commercetools.api.models.product.ProductVariantDraft;
-import com.commercetools.api.models.product.ProductVariantDraftBuilder;
+import com.commercetools.api.models.product.*;
 import com.commercetools.api.models.product_type.ProductTypeResourceIdentifierBuilder;
+import com.fasterxml.jackson.core.JsonProcessingException;
+
+import io.vrap.rmf.base.client.utils.json.JsonUtils;
 
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
@@ -37,4 +37,15 @@ public void draft() {
         Assertions.assertThat(draft.getVariants()).hasSize(1);
         Assertions.assertThat(draft.getVariants().get(0).getSku()).isEqualTo("def");
     }
+
+    @Test
+    public void serializeProduct() throws JsonProcessingException {
+        final ProductProjection productProjection = ProductProjection.builder()
+                .masterVariant(b -> b.sku("foo").id(1L))
+                .plusVariants(b -> b.sku("bar").id(2L))
+                .buildUnchecked();
+
+        Assertions.assertThat(JsonUtils.toJsonString(productProjection))
+                .isEqualTo("{\"masterVariant\":{\"id\":1,\"sku\":\"foo\"},\"variants\":[{\"id\":2,\"sku\":\"bar\"}]}");
+    }
 }