Add ShoppingList Reference Resolver helpers/utilities. #602

leungkinghin-ct · 2020-10-15T15:38:26Z

Relevant Issues

#594

Hints for Review

LineItemDraft variant selection (https://docs.commercetools.com/http-api-projects-shoppingLists#lineitemdraft-product-variant-selection) will be provided as SKU.
customer field will be supplied as ResourceIdentifier with key
custom field will be supplied as ResourceIdentifier with key
TextLineItemDraft -> custom field will be supplied as ResourceIdentifier with key
LineItemDraft -> custom field will be supplied as ResourceIdentifier with key

This reverts commit 45bf6a1.

This reverts commit b6de373.

…lverTest

….AbstractAssert.withFailMessage(String, Object[]) ignored in )

…ference-resolution

…mmercetools/commercetools-sync-java into 594-shoppinglist-reference-resolution * '594-shoppinglist-reference-resolution' of github.com:commercetools/commercetools-sync-java: Increase code coverage Update tests update message. Adapt ShoppingListDraft#Customer reference to resource identifier. `ProductDraft.getState()` is changed from `Reference<State>` to `ResourceIdentifier<State> - [Bump commercetoolsJvmSdkVersion from 1.53.0 to 1.54.0] (#589) Add test for ShoppingListReferenceResolutionUtils.java fix PMD issues. example (M C RV: Return value of org.assertj.core.api.AbstractAssert.withFailMessage(String, Object[]) ignored in ) fix check style warnings. Update ShoppingListReferenceResolutionUtils.java # Conflicts: # src/main/java/com/commercetools/sync/shoppinglists/utils/ShoppingListReferenceResolutionUtils.java

...in/java/com/commercetools/sync/shoppinglists/utils/ShoppingListReferenceResolutionUtils.java

src/test/java/com/commercetools/sync/products/ProductSyncMockUtils.java

src/test/java/com/commercetools/sync/shoppinglists/helpers/LineItemReferenceResolverTest.java

...est/java/com/commercetools/sync/shoppinglists/helpers/ShoppingListReferenceResolverTest.java

...va/com/commercetools/sync/shoppinglists/utils/ShoppingListsReferenceResolutionUtilsTest.java

leungkinghin-ct · 2020-10-19T12:09:11Z

...va/com/commercetools/sync/shoppinglists/utils/ShoppingListsReferenceResolutionUtilsTest.java

+        when(mockProductVariant.getSku()).thenReturn("variant-sku");
+
+        final List<ShoppingList> mockShoppingLists = new ArrayList<>();
+        mockShoppingLists.add(null);


what's the purpose to add a null object into the list?

To ensure that null drafts filtered out.

* master: Bump commercetoolsJvmSdkVersion from 1.54.0 to 1.55.0 Version updates and release notes of 3.0.0 (#620) 610 - Fix duration calculation for retry client. (+ refactor client creation logic) (#623) Add user guide for Shopping lists (#613) Cover shopping list line items in integration test scenarios (#626) Revert "Resolve ProductTypeSyncTest" wrapped <li> elements in <ul> tags (#616) Implement text line item actions (#625) Resolve ProductTypeSyncTest Implement LineItem actions (#618) Concept of the shopping lists' line item update actions. (#614) Bump assertj-core from 3.18.0 to 3.18.1 Implement Shoppinglist Sync class with IT/UT (exclude LineItem and TextLineItem) (#615) Add shopping list update actions (without line items) (#611) Create shoppinglist sync utils and helper (#595) Add ShoppingList Reference Resolver helpers/utilities. (#602)

leungkinghin and others added 30 commits October 13, 2020 16:32

Add ShoppingListService

2dda78a

Add shoppingList sync options, statistics and validator

b5c29a8

Add ShoppingListReferenceResolver

6e80ca4

Add LineItemReferenceResolver and TextLineItemReferenceResolver

7a21737

Modify ShoppingListReferenceResolver

9b1b5d6

Implement CustomerService (#575)

cf89dc4

Refactor ReferenceResolver classes for ShoppingList

5d3627f

Refactor CustomTypeReferenceResolutionUtils

a7da68e

Add ShoppingListReferenceResolutionUtils

45bf6a1

Update BaseSyncStatistics to be identical to master branch

0a0ecbc

Revert "Add ShoppingListReferenceResolutionUtils"

2057cf3

This reverts commit 45bf6a1.

Add ShoppingListReferenceResolutionUtils

71deb31

Merge from master branch

93e6c6e

Remove identation

a968c47

Fix indentation in ShoppingListSyncOptionsBuilderTest

b6de373

Revert "Fix indentation in ShoppingListSyncOptionsBuilderTest"

65939e1

This reverts commit b6de373.

Reformatting

874891b

Modify indentation in ShoppingListSyncOptionsBuilderTest

4654d95

Remove blank line

5d75804

Add blank line

ca1298f

Remove ShoppingListService

201e6a1

Remove classes from other featured branch

ac09cc4

Fix ReferenceResolver

51de2c4

Implement LineItemReferenceResolverTest and TextLineItemReferenceReso…

09b5ef6

…lverTest

Fix ShoppingListReferenceResolver

9d06a52

Add ShoppingListReferenceResolverTest

96464be

Update the package import for java classes

296c6ea

Update ShoppingListReferenceResolutionUtils.java

db3df2e

fix check style warnings.

823a048

fix PMD issues. example (M C RV: Return value of org.assertj.core.api…

cacac3c

….AbstractAssert.withFailMessage(String, Object[]) ignored in )

ahmetoz added 2 commits October 16, 2020 15:00

Add test for ShoppingListReferenceResolutionUtils.java

f6b7515

Merge remote-tracking branch 'origin/master' into 594-shoppinglist-re…

3d73c99

…ference-resolution

ahmetoz changed the base branch from shoppinglist-sync to shopping-lists-base-branch October 16, 2020 13:07

Adapt ShoppingListDraft#Customer reference to resource identifier.

2b6b88d

ahmetoz changed the title ~~594 shoppinglist reference resolution~~ Add ShoppingList Reference Resolver helpers/utilities. Oct 16, 2020

ahmetoz added 2 commits October 16, 2020 16:04

update message.

c65ee7d

Update tests

dff7080

ahmetoz marked this pull request as ready for review October 16, 2020 14:43

Increase code coverage

1bbeb30

ahmetoz self-requested a review October 16, 2020 14:53

leungkinghin added 3 commits October 19, 2020 11:17

Add shoppingList key into shoppingListDraft

0e05933

Add custom expansion to query variant for line items

c2240fc

lojzatran requested changes Oct 19, 2020

View reviewed changes

leungkinghin and others added 9 commits October 19, 2020 12:46

Revert last three commits

c19bd6e

Fix indentation

4856856

Fix indentation

ecdfdb1

rewords( resource -> shopping lists )

447d016

move to MockUtils from ProductSyncMockUtils.

a0a09e9

rename to ShouldNotResolveCustomTypeReferenceWithKey

197871b

rename to ShouldNotResolveCustomTypeReferenceWithKey (shopping list)

e895c7a

remove test comments.

992d11e

rename test, _ShouldReturnResourceIdentifiersWithoutReferencedKeys

2fdb1c3

ahmetoz requested a review from lojzatran October 19, 2020 11:23

ahmetoz approved these changes Oct 19, 2020

View reviewed changes

lojzatran approved these changes Oct 19, 2020

View reviewed changes

ahmetoz merged commit 9f9c837 into shopping-lists-base-branch Oct 19, 2020

ahmetoz deleted the 594-shoppinglist-reference-resolution branch October 19, 2020 11:59

leungkinghin-ct commented Oct 19, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ShoppingList Reference Resolver helpers/utilities. #602

Add ShoppingList Reference Resolver helpers/utilities. #602

leungkinghin-ct commented Oct 15, 2020 •

edited by ahmetoz

leungkinghin-ct Oct 19, 2020

ahmetoz Oct 19, 2020

Add ShoppingList Reference Resolver helpers/utilities. #602

Add ShoppingList Reference Resolver helpers/utilities. #602

Conversation

leungkinghin-ct commented Oct 15, 2020 • edited by ahmetoz

Relevant Issues

Hints for Review

leungkinghin-ct Oct 19, 2020

Choose a reason for hiding this comment

ahmetoz Oct 19, 2020

Choose a reason for hiding this comment

leungkinghin-ct commented Oct 15, 2020 •

edited by ahmetoz