Add custom object service #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## java-sdk-v2-product-sync-migration #938 +/- ##
=====================================================================
Coverage 96.46% 96.47%
- Complexity 3667 3690 +23
=====================================================================
Files 321 325 +4
Lines 10446 10494 +48
Branches 627 627
=====================================================================
+ Hits 10077 10124 +47
- Misses 274 275 +1
Partials 95 95
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
salander85
suggested changes
Apr 17, 2023
| @@ -45,7 +45,7 @@ private CustomObjectCompositeIdentifier( | |||
| */ | |||
| @Nonnull | |||
| public static CustomObjectCompositeIdentifier of( | |||
| @Nonnull final CustomObjectDraftBuilder customObjectDraftBuilder) { | |||
| @Nonnull final CustomObjectDraft customObjectDraftBuilder) { | |||
There was a problem hiding this comment.
Suggested change
| @Nonnull final CustomObjectDraft customObjectDraftBuilder) { | |
| @Nonnull final CustomObjectDraft customObjectDraft) { |
salander85
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I migrated custom object service and related classes and tests because it's required for ProductSync.