Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java sdk v2 category mock utils #962

Merged

Conversation

salander85
Copy link
Contributor

Migrate CategoryMockUtils for unittests in category-sync.

JIRA: https://commercetools.atlassian.net/browse/DEVX-73

@codecov-commenter
Copy link

Codecov Report

Merging #962 (32ee0c5) into java-sdk-v2-category-sync-migration (7937b3e) will not change coverage.
The diff coverage is n/a.

@@                          Coverage Diff                           @@
##             java-sdk-v2-category-sync-migration     #962   +/-   ##
======================================================================
  Coverage                                  95.84%   95.84%           
  Complexity                                  3900     3900           
======================================================================
  Files                                        337      337           
  Lines                                      11374    11374           
  Branches                                     695      695           
======================================================================
  Hits                                       10901    10901           
  Misses                                       364      364           
  Partials                                     109      109           

@salander85 salander85 requested a review from lojzatran May 4, 2023 14:43
}

/**
* Given a {@code locale}, {@code name}, {@code slug}, {@code key}, {@code description}, {@code
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these comments are not useful at all. This is a test class so it's probably used by us and to read the comments is much harder to understand than just to look at the code 😅

@salander85 salander85 merged commit 521d89d into java-sdk-v2-category-sync-migration May 10, 2023
@salander85 salander85 deleted the java-sdk-v2-category-mock-utils branch May 10, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants