Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-78 migrate category sync statistics #968

Conversation

lojzatran
Copy link
Collaborator

@lojzatran lojzatran commented May 10, 2023

Summary

JIRA: https://commercetools.atlassian.net/browse/DEVX-78

Note:

The following classes were already migrated in the previous PRs:

src/test/java/com/commercetools/sync/sdk2/commons/helpers/BaseSyncStatisticsTest.java
src/test/java/com/commercetools/sync/sdk2/commons/asserts/statistics/AssertionsForStatistics.java

@lojzatran lojzatran requested a review from salander85 May 10, 2023 07:42
@lojzatran lojzatran marked this pull request as ready for review May 10, 2023 07:44
@codecov-commenter
Copy link

Codecov Report

Merging #968 (17b797a) into DEVX-76_migrate_CategoryCustomActionBuilder (5368a2f) will increase coverage by 0.00%.
The diff coverage is 95.65%.

@@                              Coverage Diff                               @@
##             DEVX-76_migrate_CategoryCustomActionBuilder     #968   +/-   ##
==============================================================================
  Coverage                                          95.61%   95.61%           
- Complexity                                          3942     3950    +8     
==============================================================================
  Files                                                343      344    +1     
  Lines                                              11516    11539   +23     
  Branches                                             697      698    +1     
==============================================================================
+ Hits                                               11011    11033   +22     
- Misses                                               400      401    +1     
  Partials                                             105      105           
Impacted Files Coverage Δ
...dk2/categories/helpers/CategorySyncStatistics.java 95.65% <95.65%> (ø)

@lojzatran lojzatran merged commit b8acf76 into DEVX-76_migrate_CategoryCustomActionBuilder May 10, 2023
1 check passed
@lojzatran lojzatran deleted the DEVX-78_migrate_CategorySyncStatistics branch May 10, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants