Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-79 migrate CategoryReferenceResolutionUtils #971

Conversation

lojzatran
Copy link
Collaborator

@lojzatran lojzatran commented May 13, 2023

Summary

JIRA: https://commercetools.atlassian.net/browse/DEVX-79

Boy-scout change: I updated the method getResourceIdentifierWithKey() to return a specific ResourceIdentifier type instead of a generic ResourceIdentifier and then have to cast it.

@lojzatran lojzatran marked this pull request as ready for review May 13, 2023 14:34
@codecov-commenter
Copy link

Codecov Report

Merging #971 (85809a3) into java-sdk-v2-category-sync-migration (9176852) will increase coverage by 0.00%.
The diff coverage is 96.66%.

@@                          Coverage Diff                           @@
##             java-sdk-v2-category-sync-migration     #971   +/-   ##
======================================================================
  Coverage                                  95.62%   95.63%           
- Complexity                                  3957     3962    +5     
======================================================================
  Files                                        345      346    +1     
  Lines                                      11566    11592   +26     
  Branches                                     699      700    +1     
======================================================================
+ Hits                                       11060    11086   +26     
+ Misses                                       401      400    -1     
- Partials                                     105      106    +1     
Impacted Files Coverage Δ
...mmercetools/sync/sdk2/commons/utils/SyncUtils.java 100.00% <ø> (ø)
...gories/utils/CategoryReferenceResolutionUtils.java 91.66% <91.66%> (ø)
...mons/utils/CustomTypeReferenceResolutionUtils.java 100.00% <100.00%> (ø)
...ercetools/sync/sdk2/products/utils/PriceUtils.java 91.66% <100.00%> (ø)
...roducts/utils/ProductReferenceResolutionUtils.java 98.30% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

@salander85
Copy link
Contributor

Good work :)

@lojzatran lojzatran merged commit 4c56ced into java-sdk-v2-category-sync-migration May 15, 2023
3 checks passed
@lojzatran lojzatran deleted the DEVX-79_migrate_CategoryReferenceResolutionUtils branch May 15, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants