Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate category sync utils #974

Conversation

salander85
Copy link
Contributor

Additionally added 2 more test classes for other utils which haven't been migrated yet.

JIRA: https://commercetools.atlassian.net/browse/DEVX-82

@salander85 salander85 requested a review from lojzatran May 16, 2023 09:19
@codecov-commenter
Copy link

Codecov Report

Merging #974 (586ec38) into java-sdk-v2-category-sync-migration (9176852) will increase coverage by 0.62%.
The diff coverage is 97.56%.

@@                            Coverage Diff                            @@
##             java-sdk-v2-category-sync-migration     #974      +/-   ##
=========================================================================
+ Coverage                                  95.62%   96.25%   +0.62%     
- Complexity                                  3957     3990      +33     
=========================================================================
  Files                                        345      347       +2     
  Lines                                      11566    11613      +47     
  Branches                                     699      700       +1     
=========================================================================
+ Hits                                       11060    11178     +118     
+ Misses                                       401      332      -69     
+ Partials                                     105      103       -2     
Impacted Files Coverage Δ
...mmercetools/sync/sdk2/commons/utils/SyncUtils.java 100.00% <ø> (ø)
...gories/utils/CategoryReferenceResolutionUtils.java 91.66% <91.66%> (ø)
.../sync/sdk2/categories/utils/CategorySyncUtils.java 100.00% <100.00%> (ø)
...nc/sdk2/commons/utils/AssetsUpdateActionUtils.java 100.00% <100.00%> (+8.86%) ⬆️
...mons/utils/CustomTypeReferenceResolutionUtils.java 100.00% <100.00%> (ø)
...ercetools/sync/sdk2/products/utils/PriceUtils.java 91.66% <100.00%> (ø)
...roducts/utils/ProductReferenceResolutionUtils.java 98.30% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

@lojzatran
Copy link
Collaborator

Good job 🥳

@salander85 salander85 merged commit 6a75245 into java-sdk-v2-category-sync-migration May 17, 2023
3 checks passed
@salander85 salander85 deleted the DEVX-82_Migrate-CategorySyncUtils branch May 17, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants