-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVX-88 Migrate ProductTypeTransformUtils #981
DEVX-88 Migrate ProductTypeTransformUtils #981
Conversation
Codecov Report
@@ Coverage Diff @@
## DEVX-87_Migrate_ProductTypeReferenceResolutionUtils #981 +/- ##
=========================================================================================
- Coverage 96.27% 96.26% -0.02%
- Complexity 4041 4042 +1
=========================================================================================
Files 355 356 +1
Lines 11794 11823 +29
Branches 712 716 +4
=========================================================================================
+ Hits 11355 11381 +26
- Misses 339 340 +1
- Partials 100 102 +2
|
private CompletableFuture<Void> loadNestedProductTypeReferenceKeys( | ||
@Nonnull final List<ProductType> productTypes) { | ||
|
||
final Set<String> setOfTypeIds = new HashSet<>(collectNestedReferenceIds(productTypes)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the direct references? AttributeReferenceType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direct references are also tested in the test transform_ShouldReplaceProductTypeNestedAttributeReferenceIdsWithKeys
. The test is testing set of the direct references, so in the end they're testing what you wrote here. But for better clarity I also added a test that does not have set of references, but only a direct reference: 89f1f39
src/test/java/com/commercetools/sync/sdk2/producttypes/utils/ProductTypeTransformUtilsTest.java
Outdated
Show resolved
Hide resolved
3993946
into
DEVX-87_Migrate_ProductTypeReferenceResolutionUtils
Summary
JIRA: https://commercetools.atlassian.net/browse/DEVX-88