Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-88 Migrate ProductTypeTransformUtils #981

Conversation

lojzatran
Copy link
Collaborator

@lojzatran lojzatran requested a review from salander85 May 19, 2023 13:56
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #981 (6e0f132) into DEVX-87_Migrate_ProductTypeReferenceResolutionUtils (cabb318) will decrease coverage by 0.02%.
The diff coverage is 89.65%.

❗ Current head 6e0f132 differs from pull request most recent head 70be819. Consider uploading reports for the commit 70be819 to get more accurate results

@@                                    Coverage Diff                                    @@
##             DEVX-87_Migrate_ProductTypeReferenceResolutionUtils     #981      +/-   ##
=========================================================================================
- Coverage                                                  96.27%   96.26%   -0.02%     
- Complexity                                                  4041     4042       +1     
=========================================================================================
  Files                                                        355      356       +1     
  Lines                                                      11794    11823      +29     
  Branches                                                     712      716       +4     
=========================================================================================
+ Hits                                                       11355    11381      +26     
- Misses                                                       339      340       +1     
- Partials                                                     100      102       +2     
Impacted Files Coverage Δ
.../producttypes/utils/ProductTypeTransformUtils.java 89.65% <89.65%> (ø)

private CompletableFuture<Void> loadNestedProductTypeReferenceKeys(
@Nonnull final List<ProductType> productTypes) {

final Set<String> setOfTypeIds = new HashSet<>(collectNestedReferenceIds(productTypes));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the direct references? AttributeReferenceType

Copy link
Collaborator Author

@lojzatran lojzatran May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direct references are also tested in the test transform_ShouldReplaceProductTypeNestedAttributeReferenceIdsWithKeys. The test is testing set of the direct references, so in the end they're testing what you wrote here. But for better clarity I also added a test that does not have set of references, but only a direct reference: 89f1f39

@salander85 salander85 self-requested a review May 22, 2023 14:51
@lojzatran lojzatran merged commit 3993946 into DEVX-87_Migrate_ProductTypeReferenceResolutionUtils May 23, 2023
3 checks passed
@lojzatran lojzatran deleted the DEVX-88_Migrate_ProductTypeTransformUtils branch May 23, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants