This repository has been archived by the owner on May 24, 2023. It is now read-only.
Fix helm related float bug when using -set option #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
travis.yml
file we usually declare a global environment variableCOMMIT_HASH
as a first 8 characters of the commit hash.Although often there is at least 1 non-numeric character in first 8 characters of a commit hash, sometimes it happens to be a valid number like
**44038821**8fb11dcb6649b03f69d0eb3010260cd1
.Later we create an image with a tag which is the truncated commit hash and put to the Container Registry. Then we use this tag to push an image using Helm.
Because of the bug in Helm
--set image.tag="$COMMIT_HASH"
will be processed as a valid float type variable and become4.4038821e+07
and later will end up as an error on KubernetesIn version 2.9.0 to fix this problem Helm introduced another flag to pass a string called
--set-string
.Solution
In this PR I change Helm version to the latest one 2.9.1 and replace
--set
with--set-string
inhelm upgrade
command