fix(mc-scripts): treat *.css imports as side effects (#2887)

commercetools · Nov 18, 2022 · b0a35ec · b0a35ec · github-actions · Nov 18, 2022
1 parent c864e29
commit b0a35ec
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/.changeset/rude-cups-scream.md b/.changeset/rude-cups-scream.md
@@ -0,0 +1,5 @@
+---
+'@commercetools-frontend/mc-scripts': patch
+---
+
+Treat `*.css` imports as side effects in Webpack loaders
diff --git a/packages/mc-scripts/src/config/create-webpack-config-for-development.ts b/packages/mc-scripts/src/config/create-webpack-config-for-development.ts
@@ -360,6 +360,11 @@ function createWebpackConfigForDevelopment(
                   },
                 },
               ],
+              // Don't consider CSS imports dead code even if the
+              // containing package claims to have no side effects.
+              // Remove this when webpack adds a warning or an error for this.
+              // See https://github.com/webpack/webpack/issues/6571
+              sideEffects: true,
             },
           ],
         },

diff --git a/packages/mc-scripts/src/config/create-webpack-config-for-production.ts b/packages/mc-scripts/src/config/create-webpack-config-for-production.ts
@@ -392,6 +392,11 @@ function createWebpackConfigForProduction(
                   },
                 },
               ],
+              // Don't consider CSS imports dead code even if the
+              // containing package claims to have no side effects.
+              // Remove this when webpack adds a warning or an error for this.
+              // See https://github.com/webpack/webpack/issues/6571
+              sideEffects: true,
             },
           ],
         },