feat: add message for OverlappingPriceValidity error code

commercetools · May 9, 2024 · c319ff6 · c319ff6
1 parent f8f413c
commit c319ff6
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/packages/i18n/data/core.json b/packages/i18n/data/core.json
@@ -71,6 +71,10 @@
     "developer_comment": "User attempts to create a resource while having already reached the limit",
     "string": "The project reached the limit for the resource. To add more resources delete existing ones or reach out to the administrator or contact customer support."
   },
+  "ApiError.OverlappingPriceValidity": {
+    "developer_comment": "Returned when a given price validity period conflicts with an existing one",
+    "string": "Two prices have overlapping validity periods."
+  },
   "ApiError.OverlappingPrices": {
     "developer_comment": "",
     "string": "Sorry, but a price with these details already exists. Please amend the price details so that they do not overlap with another price before saving."

diff --git a/...ifications/src/components/notification-kinds/api-error-message/api-error-message.spec.tsx b/...ifications/src/components/notification-kinds/api-error-message/api-error-message.spec.tsx
@@ -284,6 +284,16 @@ describe('render', () => {
       )
     ).toBeInTheDocument();
   });
+  it('should show message for OverlappingPriceValidity', () => {
+    const error = {
+      extensions: { code: 'OverlappingPriceValidity' },
+      message: 'message-content',
+    };
+    renderMessage(<ApiErrorMessage error={error} />);
+    expect(
+      screen.getByText('Two prices have overlapping validity periods.')
+    ).toBeInTheDocument();
+  });
   it('should show message for OverlappingStandalonePriceValidity', () => {
     const error = {
       extensions: { code: 'OverlappingStandalonePriceValidity' },

diff --git a/packages/react-notifications/src/components/notification-kinds/api-error-message/messages.ts b/packages/react-notifications/src/components/notification-kinds/api-error-message/messages.ts
@@ -97,6 +97,12 @@ export default defineMessages({
     defaultMessage:
       'Slugs may only contain alphanumeric (0-9A-Z) characters, underscores and hyphens and must have a length between 2 and 256 characters.',
   },
+  OverlappingPriceValidity: {
+    id: 'ApiError.OverlappingPriceValidity',
+    description:
+      'Returned when a given price validity period conflicts with an existing one',
+    defaultMessage: 'Two prices have overlapping validity periods.',
+  },
   OverlappingStandalonePriceValidity: {
     id: 'ApiError.OverlappingStandalonePriceValidity',
     description: