-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update react-intl
to ^5.25.0
#2563
Conversation
🦋 Changeset detectedLatest commit: 443401b The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I agree we need to update app-kit's Or maybe I'm seeing a problem that actually would not exist. |
Thanks, I guess adding some instructions would be a nice help for the users but perhaps it will be unnoticed in this changeset in the long run. This has been brought up on several occasions in the github issues, i.e. today. I can only guess that users will see it there, but I can add it also here it's totally up to you |
We can create a github discussion and provide the answers. |
Just because this already showed up a couple of times in the issues I was thinking about having some kind of instructions to our users which we could use as reference. I think @emmenko's idea about having a github discussion with some instructions on how to debug this kind of problem in the best approach. |
@CarlosCortizasCT @kark Do you want to work on the Q/A part in the GitHub Discussions? It can be something similar to this: #2479 Essentially, you ask the question and answer to your own question 😄 |
Sure, I can do that 😅 |
Summary
This PR bumps
react-intl
to the newest caret version.Additionally,
react-intl
is removed fromresolutions
section in the mainpackage.json
Context
As the caret version of the package is used in the
ui-kit
, it may cause conflicts of the mismatched versions if an application uses bothui-kit
packages andapp-kit
packages.For instance:
ui-kit
uses^5.24.6
version which currently resolves to5.25.0
. Version pinned inapp-kit
is5.24.8
which results inCould not find required 'intl' object
error if an application uses the latest versions of packages from both repos.