Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update react-intl to ^5.25.0 #2563

Merged
merged 2 commits into from
Apr 21, 2022
Merged

chore: update react-intl to ^5.25.0 #2563

merged 2 commits into from
Apr 21, 2022

Conversation

kark
Copy link
Contributor

@kark kark commented Apr 21, 2022

Summary

This PR bumps react-intl to the newest caret version.
Additionally, react-intl is removed from resolutions section in the main package.json

Context

As the caret version of the package is used in the ui-kit, it may cause conflicts of the mismatched versions if an application uses both ui-kit packages and app-kit packages.
For instance: ui-kit uses ^5.24.6 version which currently resolves to 5.25.0. Version pinned in app-kit is 5.24.8 which results in Could not find required 'intl' object error if an application uses the latest versions of packages from both repos.

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2022

🦋 Changeset detected

Latest commit: 443401b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
merchant-center-application-template-starter Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/react-notifications Patch
playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/custom-applications Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
merchant-center-application-kit ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 10:28AM (UTC)

@kark kark requested a review from a team April 21, 2022 10:42
@CarlosCortizasCT
Copy link
Contributor

I agree we need to update app-kit's react-intl version to use a caret range indicator, but I'm not sure if it could cause problems for users when updating.
If I currently have both ui-kit and 'app-kitdependencies and update onlyapp-kit, it will use version 5.25.0but will not makeui-kitdependencies to update to this new versions so maybe I end up with different versions in my _node_modules_ directory and I might need to runyarn up -R react-intl` to solve it.
If this is the case, perhaps we could add some instructions in the changeset file.

Or maybe I'm seeing a problem that actually would not exist.

@kark
Copy link
Contributor Author

kark commented Apr 21, 2022

I agree we need to update app-kit's react-intl version to use a caret range indicator, but I'm not sure if it could cause problems for users when updating. If I currently have both ui-kit and 'app-kitdependencies and update onlyapp-kit, it will use version 5.25.0but will not makeui-kitdependencies to update to this new versions so maybe I end up with different versions in my _node_modules_ directory and I might need to runyarn up -R react-intl` to solve it. If this is the case, perhaps we could add some instructions in the changeset file.

Or maybe I'm seeing a problem that actually would not exist.

Thanks, I guess adding some instructions would be a nice help for the users but perhaps it will be unnoticed in this changeset in the long run. This has been brought up on several occasions in the github issues, i.e. today. I can only guess that users will see it there, but I can add it also here it's totally up to you

@emmenko
Copy link
Member

emmenko commented Apr 21, 2022

We can create a github discussion and provide the answers.

@CarlosCortizasCT
Copy link
Contributor

Just because this already showed up a couple of times in the issues I was thinking about having some kind of instructions to our users which we could use as reference.

I think @emmenko's idea about having a github discussion with some instructions on how to debug this kind of problem in the best approach.

@emmenko
Copy link
Member

emmenko commented Apr 21, 2022

@CarlosCortizasCT @kark Do you want to work on the Q/A part in the GitHub Discussions?

It can be something similar to this: #2479

Essentially, you ask the question and answer to your own question 😄

@kark
Copy link
Contributor Author

kark commented Apr 21, 2022

@CarlosCortizasCT @kark Do you want to work on the Q/A part in the GitHub Discussions?

It can be something similar to this: #2479

Essentially, you ask the question and answer to your own question 😄

Sure, I can do that 😅

@kark kark merged commit 238bd34 into main Apr 21, 2022
@kark kark deleted the kk-react-intl-update branch April 21, 2022 14:07
@ghost ghost mentioned this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants