-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update percy to v1.1 #2596
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
{ | ||
"matchPackageNames": ["@percy/puppeteer"], | ||
"allowedVersions": "<=2.0.0" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See related issue for Jest/ESM support, which was added to @percy/puppeteer
on v2.0.1
.
For now, we downgrade to v2.0.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to link things together, we needed to do the same in ui-kit.
@@ -7,5 +7,6 @@ module.exports = { | |||
command: 'yarn visual-testing-app:preview', | |||
port: 3000, | |||
launchTimeout: 10000, | |||
debug: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To help debugging issues on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Extracting Percy dep updates from #2555