refactor: apply new design tokens for appbar and user menu #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4442548 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emmenko
commented
Dec 16, 2022
| @@ -4,6 +4,7 @@ import { | |||
| } from '@commercetools-uikit/design-system'; | |||
|
|
|||
| const appKitSpacing55 = '40px'; | |||
| const newShadow1 = '0px 2px 5px 0px rgba(0, 0, 0, 0.15)'; | |||
There was a problem hiding this comment.
Would be moved to uikit, as it's one of the new shadows.
emmenko
commented
Dec 16, 2022
Comment on lines
-169
to
+167
| width: 225px; | ||
| width: ${designTokens.constraint6}; |
There was a problem hiding this comment.
It's fine to change it in general
emmenko
commented
Dec 16, 2022
| @@ -1,5 +1,6 @@ | |||
| export const DIMENSIONS = { | |||
| header: '43px', | |||
| header: '56px', | |||
There was a problem hiding this comment.
It's fine to change it in general
emmenko
commented
Dec 16, 2022
| @@ -103,7 +104,7 @@ const AppBar = (props: Props) => { | |||
| <div | |||
| css={css` | |||
| border-left: 1px ${customProperties.colorNeutral90} solid; | |||
| height: ${DIMENSIONS.header}; | |||
| height: ${DIMENSIONS.headerItemDivider}; | |||
There was a problem hiding this comment.
It's fine to change it in general
|
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 4442548. |
packages/application-shell/src/components/project-switcher/project-switcher.tsx
Show resolved
Hide resolved
packages/application-shell/src/components/user-settings-menu/user-settings-menu.tsx
Show resolved
Hide resolved
packages/application-shell/src/components/user-settings-menu/user-settings-menu.tsx
Outdated
Show resolved
Hide resolved
packages/application-shell/src/components/user-settings-menu/user-settings-menu.tsx
Outdated
Show resolved
Hide resolved
kark
approved these changes
Dec 19, 2022
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already checked with @FilPob and is approved from his side.