Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(application-components): add themeParentSelector prop to PageContentWide #2987

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

kark
Copy link
Contributor

@kark kark commented Mar 9, 2023

Summary

Add themeParentSelector prop to PageContentWide.
It's needed for the MC WelcomePage refactor.

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

🦋 Changeset detected

Latest commit: a43a3ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-shell Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/custom-applications Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-dmdbzkdy5-commercetools.vercel.app
https://appkit-sha-f5f2b7d02d1c4d4ed69e5114dc3629cedd19d79d.commercetools.vercel.app
https://appkit-pr-2987.commercetools.vercel.app

Built with commit a43a3ee.
This pull request is being automatically deployed with vercel-action

@kark kark requested a review from a team March 9, 2023 13:53
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the new VRT screenshot, but it does not seem related to this change.

@kark
Copy link
Contributor Author

kark commented Mar 9, 2023

Not sure about the new VRT screenshot, but it does not seem related to this change.

Hmm, yes, it made me wonder what happened to the baseline image for this view

@emmenko
Copy link
Member

emmenko commented Mar 10, 2023

Weird indeed. Let's approve it.

@kark kark merged commit 7f2ede7 into main Mar 10, 2023
@kark kark deleted the kk-pagecontentwide-with-themeparentselector-prop branch March 10, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants