Support Custom Views local development #3175

CarlosCortizasCT · 2023-08-22T09:24:59Z

Summary

This PR focuses on creating a new starter template to bootstrap a Custom View and to allow running it locally.

Description

Most of the change files are actually the new files for the new template, which was created based on the Custom Applications typescript starter template.
The main two differences are:

It has a different configuration file (named custom-view-config)
It does not use the ApplicationShell component in its entry-point but new components tailored to run the Custom View locally:
- CustomViewShell: new main wrapper for Custom Views
- CustomViewDevHost: new component to emulate a local host application where we can run the Custom View from

Other relevant changes are:

Custom Views have their config file with its validation, so the process for loading, processing and validating the configuration has been updated. We just updated the current application-config package instead of creating a new one for Custom Views.
There's a new component which abstracts away the logic to run a Custom View locally: CustomDevHost.
We also have new helpers dedicated to Custom View tests.

changeset-bot · 2023-08-22T09:25:04Z

🦋 Changeset detected

Latest commit: c9b9128

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@commercetools-frontend/application-shell-connectors	Minor
@commercetools-frontend/application-shell	Minor
@commercetools-frontend/application-config	Minor
@commercetools-frontend/mc-html-template	Minor
@commercetools-frontend/permissions	Minor
@commercetools-frontend/mc-scripts	Minor
@commercetools-frontend/constants	Minor
@commercetools-frontend/cypress	Minor
@commercetools-frontend/i18n	Minor
@commercetools-frontend/sdk	Minor
@commercetools-frontend/application-components	Minor
@commercetools-applications/merchant-center-custom-view-template-starter-typescript	Minor
@commercetools-applications/merchant-center-template-starter-typescript	Minor
@commercetools-applications/merchant-center-template-starter	Minor
@commercetools-local/playground	Minor
@commercetools-website/custom-applications	Minor
@commercetools-frontend/mc-dev-authentication	Minor
@commercetools-local/visual-testing-app	Minor
@commercetools-website/components-playground	Minor
@commercetools-frontend/actions-global	Minor
@commercetools-frontend/react-notifications	Minor
@commercetools-frontend/sentry	Minor
@commercetools-frontend/codemod	Minor
@commercetools-frontend/l10n	Minor
@commercetools-backend/eslint-config-node	Minor
@commercetools-backend/express	Minor
@commercetools-backend/loggers	Minor
@commercetools-frontend/assets	Minor
@commercetools-frontend/babel-preset-mc-app	Minor
@commercetools-frontend/browser-history	Minor
@commercetools-frontend/create-mc-app	Minor
@commercetools-frontend/eslint-config-mc-app	Minor
@commercetools-frontend/jest-preset-mc-app	Minor
@commercetools-frontend/jest-stylelint-runner	Minor
@commercetools-frontend/notifications	Minor
@commercetools-frontend/url-utils	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-08-30T08:54:26Z

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-jc756w9bk-commercetools.vercel.app
https://appkit-sha-9e90d53ac1ab0951092b1f45416064ec6066466d.commercetools.vercel.app
https://appkit-pr-3175.commercetools.vercel.app

Built with commit c9b9128.
This pull request is being automatically deployed with vercel-action

CarlosCortizasCT · 2023-09-04T07:16:51Z

...application-components/src/components/custom-views/custom-view-loader/custom-view-loader.tsx

@@ -92,7 +93,7 @@ function CustomViewLoader(props: TCustomViewLoaderProps) {
        context: {
          dataLocale: appContext.dataLocale,
          customViewConfig: props.customView,
-          hostUrl: window.location.href,
+          hostUrl: props.hostUrl || window.location.href,


This allows for mocking the URL in the local custom-view development template

CarlosCortizasCT · 2023-09-04T07:17:48Z

packages/application-config/custom-view.schema.json

@@ -0,0 +1,206 @@
+{


Custom Views have a slightly different configuration requirements than Custom Apps, so that's why we renamed the previous schema and created this one.

CarlosCortizasCT · 2023-09-04T07:18:22Z

packages/application-config/package.json

-    "build:schema": "json2ts schema.json src/schema.ts --style.singleQuote --bannerComment '/* eslint-disable prettier/prettier */\n// This file was automatically generated by json-schema-to-typescript.\n// DO NOT MODIFY IT BY HAND. Instead, modify the source schema.json file.'"
+    "build:customApplicationSchema": "json2ts custom-application.schema.json src/custom-application.schema.ts --style.singleQuote --bannerComment '/* eslint-disable prettier/prettier */\n// This file was automatically generated by json-schema-to-typescript.\n// DO NOT MODIFY IT BY HAND. Instead, modify the source custom-application.schema.json file and run the build:schemas npm script.'",
+    "build:customViewSchema": "json2ts custom-view.schema.json src/custom-view.schema.ts --style.singleQuote --bannerComment '/* eslint-disable prettier/prettier */\n// This file was automatically generated by json-schema-to-typescript.\n// DO NOT MODIFY IT BY HAND. Instead, modify the source custom-view.schema.json file and run the build:schemas npm script.'",
+    "build:schemas": "pnpm build:customApplicationSchema && pnpm build:customViewSchema"


We now have to manage two schemas for configuration files (Custom Applications and Custom Views).

CarlosCortizasCT · 2023-09-04T07:19:27Z

packages/application-config/src/load-config.ts

+const customApplicationExplorer = getExplorer('custom-application-config');
+const customViewExplorer = getExplorer('custom-view-config');


We need to be able to load config files for both Custom Applications and Custom Views

packages/application-config/src/load-config.ts

CarlosCortizasCT · 2023-09-04T07:33:31Z

packages/application-config/test/process-config.spec.js

@@ -26,7 +26,10 @@ beforeEach(() => {

 describe('processing a simple config', () => {
  beforeEach(() => {
-    loadConfig.mockReturnValue(fixtureConfigSimple);
+    loadConfig.mockReturnValue({


This function now returns not only the configuration but also the filename, so we need to update all these mocks.

CarlosCortizasCT · 2023-09-04T07:34:22Z

packages/application-shell/src/components/authenticated/authenticated.tsx

@@ -52,6 +52,14 @@ const AuthenticationRoutes = (props: TAuthenticatedProps) => (
        applicationMessages={props.applicationMessages}
      />
    </SuspendedRoute>
+    <SuspendedRoute


We use this new route in Custom Views local auth flow.

CarlosCortizasCT · 2023-09-04T07:42:19Z

packages/application-shell/src/components/custom-view-dev-host/custom-view-dev-host.tsx

+  children: ReactNode;
+};
+
+const CustomViewDevHost = (props: TCustomViewDevHost) => {


This component is used as the landing page for Custom Views local development so users can use a Custom Application like host to trigger rendering the Custom View as it will be done in the Merchant Center.

CarlosCortizasCT · 2023-09-04T07:43:58Z

packages/jest-preset-mc-app/setup-tests.js

@@ -1,4 +1,5 @@
 const util = require('util');
+const { MessageChannel } = require('worker_threads');


This is needed to emulate how we create a private messages channel between host and Custom View in the test environment.

CarlosCortizasCT · 2023-09-04T07:50:19Z

patches/jsdom@20.0.3.patch

+
+ module.exports = function (globalObject) {
+-  return function (message, targetOrigin) {
+  return function (message, targetOrigin, ports) {


We use the third parameter of postMessage in our code to create the private channel between the host application and the Custom View but jsdom does not support it yet:

Here is where they have a TODO about it

There's this issue asking for its support

Here's a PR trying to implement this missing functionality (already 4 months old)

Since our case is very basic, I implemented this simplistic patch so it works in our tests.

Not needed anymore as we are now mocking this part in a different way (mock the providers instead of relying on the communication to happen in the tests environment).

Just leave the comment here for reference purposes.

CarlosCortizasCT · 2023-09-04T08:25:28Z

packages/application-shell/src/test-utils/custom-views-utils.tsx

@@ -0,0 +1,107 @@
+import { type ReactNode, useEffect, useRef } from 'react';


This new file contains helpers specific for Custom Views tests so we don't have to include them in the template so we keep control over them.

CarlosCortizasCT · 2023-09-04T08:28:01Z

custom-views-templates/starter-typescript/src/components/channels/channels.tsx

+          {intl.formatMessage(messages.subtitle, {
+            firstName: customViewContext.user?.firstName,
+            lastName: customViewContext.user?.lastName,
+          })}


This is just to showcase how to access information from the context.

CarlosCortizasCT · 2023-09-04T08:28:48Z

custom-views-templates/starter-typescript/src/components/entry-point/entry-point.tsx

+  if (process.env.NODE_ENV === 'development') {
+    return (
+      <CustomViewDevHost
+        environment={environment}
+        applicationMessages={loadMessages}
+      >
+        <CustomViewMain
+          customViewId={environment.customViewId}
+          messages={loadMessages}
+        />
+      </CustomViewDevHost>
+    );
+  }


Locally we use the new component to emulate a MC application where we can trigger the Custom View from.

CarlosCortizasCT · 2023-09-04T08:30:30Z

custom-views-templates/starter-typescript/src/test-utils/index.tsx

+import { graphql } from 'msw';
+import { mapResourceAccessToAppliedPermissions } from '@commercetools-frontend/application-shell/test-utils';
+
+export const getDefaultCustomViewServerMocks = () => [


I would like to move this to the new Custom views test utils file (in the application-shell package) but that would imply to include msw as a dependency of that package and we don't want that (would be bloating the bundle size).

CarlosCortizasCT · 2023-09-06T08:21:05Z

packages/permissions/src/hooks/use-is-authorized/use-is-authorized.ts

-    (applicationContext) =>
-      projectPermissions?.dataFences ?? applicationContext.dataFences
-  );
+  const { resolvedPermissions, resolvedActionRights, resolvedDataFences } =


Up until now we were reading the permissions from the application context but this is not enough when using this hook from a Custom View, since we won't have them over there but in the custom view context so I decided to create a private utility function to try to fetch permissions from both so we don't need to change the signature of this hook or create a new one.

I'm a bit confused. Isn't the ApplicationContext also used in Custom Views? The permissions are usually exposed from the FetchProject data and mapped into the application context.

I'm also wondering if we really need a separate context for Custom Views but (re)use the Application Context and inject some customView specific data.

Let's have a chat about this maybe.

Yes, that change wasn't actually needed. I implemented it at some point where things were not working but I think I then solved it the right way.
I rolled back that change in this commit: f4caaf5

Regarding unifying contexts, I still believe is better for organization to have different ones serving different purposes.
Also, the new one would not change at runtime because it's for improve context data to be easily available throughout the Custom View code and it will be populated with the (static) data received from the host application.

CarlosCortizasCT · 2023-09-06T08:22:16Z

...ion-shell/src/components/custom-view-shell-authenticated/custom-view-shell-authenticated.tsx

                            return (
                              <ApplicationContextProvider
                                user={user}
                                project={project}
                                projectDataLocale={props.dataLocale}
                                environment={props.environment}
                              >
-                                {props.children}
+                                <CustomViewWithPermissionCheck


We make sure the user has, at least, view permission for the current custom view.

emmenko

Awesome work so far, definitely lots of places that depend on each other. Hopefully that helps you to better understand the setup 💪

I went through the changes and I ended up having several questions and clarification points.

Let's have a sync to discuss them, thanks 🤗

emmenko · 2023-09-07T10:36:04Z

website/scripts/prebuild.sh

@@ -4,4 +4,4 @@ set -e

 # Copy the custom application config `schema.json` to the website static assets.
 echo "Copying JSON schema for Custom Applications"
-cp ../packages/application-config/schema.json static/
+cp ../packages/application-config/custom-application.schema.json static/


⚠️ This is a breaking change. Can we keep the schema.json, at least for backwards compatibility?

Ok, I guess I didn't realized this is how we host the schema publicly, right?
Perhaps we can have this kind of configuration instead:

cp ../packages/application-config/custom-application.schema.json static/schema.json cp ../packages/application-config/custom-application.schema.json static/ cp ../packages/application-config/custom-view.schema.json static/

packages/application-config/custom-view.schema.json

emmenko · 2023-09-07T10:42:54Z

packages/application-config/custom-view.schema.json

Nit: wondering if it would make sense to reference parts of this schema from the Custom Application schema (I think using the $ref keyword: https://json-schema.org/understanding-json-schema/structuring.html#ref), just to avoid duplication.

packages/application-config/src/load-config.ts

emmenko · 2023-09-07T10:46:43Z

packages/application-config/src/process-config.ts

+  if (configFileName.includes('custom-application-config')) {
+    return ConfigType.CUSTOM_APPLICATION;
+  } else if (configFileName.includes('custom-view-config')) {
+    return ConfigType.CUSTOM_VIEW;
+  } else {
+    throw new Error(`Invalid config filename: ${configFileName}`);
+  }


Nit: the config filename cannot be invalid, as otherwise cosmiconfig should already throw.

Maybe here we can simply check for the custom-view-config file name and fall back to a Custom Application.

Thanks.

Update here: 698d360

emmenko · 2023-09-07T10:57:03Z

packages/application-config/src/transformers.ts

+    permissions: getPermissions(customViewConfig),
+    type: customViewConfig.type,
+    typeSettings: customViewConfig.typeSettings,
+    hostUrl: customViewConfig.env.development.hostUrl,


Does this need to be exposed here, since it's only defined in development?

Yes this is used only in development so we can load the emulated host URL from the configuration file (you can see it in the line of the entry point file).

Maybe there is another way of doing it so I'm open for suggestions.

emmenko · 2023-09-07T10:59:07Z

...ages/application-shell-connectors/src/components/custom-view-context/custom-view-context.tsx

-  const context = useContext(CustomViewContext);
-  if (!context) {
+type TMergedContext = TCustomViewContext & TApplicationContext<{}>;
+export function useCustomViewContext(): TMergedContext {


Can you add a note to implement the selector with function overloading?

emmenko · 2023-09-07T11:03:53Z

packages/permissions/src/hooks/use-is-authorized/use-is-authorized.ts

+  const customApplicationContext = useApplicationContext();
+  const customViewContext = useCustomViewContext();


If a context is not defined, does it throw an error if you try to access it?

Currently the context always have an empty config by default so it won't throw an error.

emmenko · 2023-09-07T12:12:46Z

packages/permissions/src/hooks/use-is-authorized/use-is-authorized.ts

-    (applicationContext) =>
-      projectPermissions?.dataFences ?? applicationContext.dataFences
-  );
+  const { resolvedPermissions, resolvedActionRights, resolvedDataFences } =


I'm a bit confused. Isn't the ApplicationContext also used in Custom Views? The permissions are usually exposed from the FetchProject data and mapped into the application context.

I'm also wondering if we really need a separate context for Custom Views but (re)use the Application Context and inject some customView specific data.

Let's have a chat about this maybe.

emmenko · 2023-09-07T12:13:32Z

packages/application-shell/src/components/custom-view-dev-host/custom-view-dev-host.tsx

+const defaultCustomViewConfig: TCustomView = {
+  createdAt: '',
+  defaultLabel: '',
+  id: Date.now().toString(),
+  installedBy: [],
+  labelAllLocales: {},
+  locators: [],
+  owner: {
+    createdAt: '',
+    id: '',
+    organizationId: '',
+    updatedAt: '',
+  },
+  ownerId: '',
+  permissions: [],
+  status: TCustomViewStatus.Draft,
+  type: TCustomViewType.CustomPanel,
+  typeSettings: {
+    size: TCustomViewSize.Small,
+  },
+  updatedAt: '',
+  url: '',
+};


Does this need to be hardcoded here? Isn't this parsed and loaded from the config file? 🤔

We don't have all the information in the config file.
This will come from the host application in runtime but I didn't want to have a null value in the context for starters.

emmenko · 2023-09-15T10:29:39Z

...ages/application-shell-connectors/src/components/custom-view-context/custom-view-context.tsx

+// Use function overloading to declare two possible signatures with two
+// distict return types, based on the selector function argument.
+function useCustomViewContextHook(): TCustomViewContext;
+function useCustomViewContextHook<SelectedContext>(
+  selector: (context: TCustomViewContext) => SelectedContext
+): SelectedContext;
+
+// Then implement the function. Typescript will pick the appropriate signature
+// based on the function arguments.
+function useCustomViewContextHook<SelectedContext>(
+  selector?: (context: TCustomViewContext) => SelectedContext
+) {
+  const context = useContext(Context);
+  // Because of the way the CustomViewShell configures the Context.Provider,
+  // we ensure that, when we read from the context, we always get actual
+  // context object and not the initial value.
+  // Therefore, we can safely cast the value to be out `TCustomViewContext` type.
+  const customViewContext = context as TCustomViewContext;
+  return selector ? selector(customViewContext) : customViewContext;
+}
+
+// This is a workaround to trick babel/rollup to correctly export the function.
+// Most likely the problem arises with the use of overloading.
+// See related issue: https://github.com/babel/babel/issues/8361
+const useCustomViewContext = useCustomViewContextHook;


Same as for useApplicationContext, we provide the ability to pass a selector function.

emmenko · 2023-09-15T10:32:28Z

packages/application-shell/src/components/custom-view-loader/custom-view-loader.tsx

+  const iFrameUrl = [
+    window.location.origin,
+    'custom-views',
+    props.customView.id,
+    'projects',
+    projectKey,
+  ].join('/');


This would be the new route in the MC Proxy to serve the Custom Views

emmenko · 2023-09-15T10:34:08Z

...ion-shell/src/components/custom-view-shell-authenticated/custom-view-shell-authenticated.tsx

+  const permissionKeys = entryPointUriPathToPermissionKeys(props.customViewId);
+
+  // Require View permission to render the application.
+  const canView = useIsAuthorized({
+    demandedPermissions: [permissionKeys.View],
+  });


Currently this always yields false, until we adjust the applied permissions logic in the MC API to expose the computed permission keys for Custom Views (for local development).

emmenko · 2023-09-15T10:35:05Z

packages/application-shell/src/components/custom-view-shell/custom-view-shell.tsx

+  if (process.env.NODE_ENV === 'development' && !props.disableDevHost) {
+    return (
+      <Suspense fallback={<ApplicationLoader />}>
+        <CustomViewDevHost applicationMessages={props.applicationMessages}>
+          <CustomViewShell applicationMessages={props.applicationMessages}>
+            {props.children}
+          </CustomViewShell>
+        </CustomViewDevHost>
+      </Suspense>
+    );
+  }


For local development we're wrapping the <CustomViewShell> with <CustomViewDevHost>

emmenko · 2023-09-15T10:51:22Z

playground/src/components/custom-views/demo-custom-view.jsx

+    window.app.applicationIdentifier = `__local:${CUSTOM_VIEW_HOST_ENTRY_POINT_URI_PATH}`;
+    window.app.customViewId = CUSTOM_VIEW_ID;
+    window.app.__DEVELOPMENT__.customViewConfig = DEMO_CUSTOM_VIEW;
+    window.app.__DEVELOPMENT__.customViewHostUrl = window.location.href;


For now it's fine but it's not very maintainable like this.

emmenko · 2023-09-15T10:52:26Z

playground/src/components/custom-views/demo-custom-view.jsx

@@ -78,7 +88,7 @@ function DemoCustomView() {
  }

  return (
-    <CustomViewShell customViewId={CUSTOM_VIEW_ID} messages={{}}>
+    <CustomViewShell disableDevHost applicationMessages={{}}>


Since we are rendering the <CustomViewDevHost> from within the <CustomViewShell>, we need to explicitly opt out of it even in development, as the setup we have in playground does not need that component.

emmenko

Alright, there are some follow ups to look into but overall it's good to go from my side! 🚀

Amazing job Carlos for the core and demo setups. Looking forward to see this in action in the Merchant Center 🙌

Rhotimee

This looks great! Thanks @CarlosCortizasCT and @emmenko.

I left some minor suggestions but, generally, it's solid work.

🚀

Rhotimee · 2023-09-18T07:48:37Z

custom-views-templates/starter-typescript/custom-view-config.mjs

+  env: {
+    development: {
+      // TODO: This should be populated in the template installation process
+      initialProjectKey: 'almond-40',


NIT

Suggested change

initialProjectKey: 'almond-40',

initialProjectKey: '${env:CTP_INITIAL_PROJECT_KEY}'

Thanks 8700882

Rhotimee · 2023-09-18T07:54:36Z

custom-views-templates/starter-typescript/src/components/entry-point/entry-point.tsx

+  <CustomViewShell applicationMessages={loadMessages}>
+    <AsyncApplicationRoutes />
+  </CustomViewShell>


Rhotimee · 2023-09-18T08:01:53Z

.changeset/nervous-bags-clap.md

+'@commercetools-frontend/application-shell': patch
+---
+
+Move component to application-shell package


NIT: It will be nice to know the component(s) that were moved.

Suggested change

Move component to application-shell package

Move CustomViewLoader to application-shell package

Thanks 0f94a4a

Rhotimee · 2023-09-18T08:19:01Z

packages/application-config/src/process-config.ts

+      : `/${entryPointUriPath}`;
+    const hostUrl = new URL(
+      hostUriPath || defaultHostUriPath,
+      'http://localhost:3001'


Suggested change

'http://localhost:3001'

developmentAppUrl

Good catch! 88ef166

Rhotimee · 2023-09-18T08:22:19Z

packages/application-config/src/process-config.ts

+  const entryPointUriPath = isCustomViewData(configurationData)
+    ? // When the application acts as the host for Custom Views, there is no real
+      // entry point to be used, therefore we use a special identifier.
+      CUSTOM_VIEW_HOST_ENTRY_POINT_URI_PATH
+    : configurationData.entryPointUriPath;


That is a very good idea 🙌🏽

Rhotimee · 2023-09-18T08:45:17Z

playground/src/components/custom-views/constants.js

+import {
+  TCustomViewSize,
+  TCustomViewType,
+} from '@commercetools-frontend/application-shell';


Suggested change

import {

TCustomViewSize,

TCustomViewType,

} from '@commercetools-frontend/application-shell';

import type {

TCustomViewSize,

TCustomViewType,

} from '@commercetools-frontend/application-shell';

These are enums...actually let me remove these exports, we don't really need them. 4894226

CarlosCortizasCT added the 🚧 Status: WIP Work in progress label Aug 22, 2023

Base automatically changed from SHIELD-843-custom-views-shell to main August 30, 2023 08:01

github-actions bot deployed to Preview August 30, 2023 08:53 View deployment

CarlosCortizasCT self-assigned this Sep 1, 2023

CarlosCortizasCT commented Sep 4, 2023

View reviewed changes

CarlosCortizasCT changed the title ~~Update mc-scripts cli to support Custom Views~~ Allowing running a Custom View locally Sep 4, 2023

CarlosCortizasCT commented Sep 4, 2023

View reviewed changes

github-actions bot deployed to Preview September 4, 2023 08:27 View deployment

CarlosCortizasCT commented Sep 4, 2023

View reviewed changes

github-actions bot deployed to Preview September 4, 2023 08:47 View deployment

github-actions bot deployed to Preview September 5, 2023 14:45 View deployment

github-actions bot deployed to Preview September 5, 2023 15:07 View deployment

github-actions bot deployed to Preview September 5, 2023 15:16 View deployment

github-actions bot deployed to Preview September 6, 2023 08:16 View deployment

CarlosCortizasCT commented Sep 6, 2023

View reviewed changes

github-actions bot deployed to Preview September 6, 2023 08:36 View deployment

github-actions bot deployed to Preview September 6, 2023 10:33 View deployment

github-actions bot deployed to Preview September 6, 2023 10:48 View deployment

github-actions bot deployed to Preview September 6, 2023 11:03 View deployment

github-actions bot deployed to Preview September 6, 2023 11:09 View deployment

github-actions bot deployed to Preview September 6, 2023 15:41 View deployment

CarlosCortizasCT mentioned this pull request Sep 6, 2023

Update create-mc-app CLI to support creating custom views #3201

Merged

github-actions bot deployed to Preview September 7, 2023 08:05 View deployment

emmenko reviewed Sep 7, 2023

View reviewed changes

github-actions bot deployed to Preview September 7, 2023 13:23 View deployment

emmenko reviewed Sep 15, 2023

View reviewed changes

refactor: leftovers

6ec7920

emmenko changed the title ~~Allowing running a Custom View locally~~ Support Custom Views local development Sep 15, 2023

emmenko marked this pull request as ready for review September 15, 2023 10:53

github-actions bot deployed to Preview September 15, 2023 10:55 View deployment

Rhotimee self-requested a review September 15, 2023 12:21

docs: changesets

e0685c0

emmenko removed the 🚧 Status: WIP Work in progress label Sep 15, 2023

github-actions bot deployed to Preview September 15, 2023 14:34 View deployment

emmenko approved these changes Sep 15, 2023

View reviewed changes

chore: increase test timeout for visual tests

1cc50ef

github-actions bot deployed to Preview September 18, 2023 07:48 View deployment

Rhotimee approved these changes Sep 18, 2023

View reviewed changes

emmenko added 4 commits September 18, 2023 11:32

refactor: remove unnecessary exports

4894226

docs: improve description

0f94a4a

refactor: use variable

88ef166

refactor: use placeholder variable

8700882

github-actions bot deployed to Preview September 18, 2023 09:36 View deployment

github-actions bot deployed to Preview September 18, 2023 09:38 View deployment

fix: leftover

c9b9128

github-actions bot deployed to Preview September 18, 2023 11:22 View deployment

emmenko merged commit bd9df94 into main Sep 18, 2023
14 checks passed

emmenko deleted the SHIELD-846-custom-views-mc-scripts branch September 18, 2023 12:49

merchant-center-automation mentioned this pull request Sep 18, 2023

Version Packages #3199

Merged

emmenko mentioned this pull request Sep 26, 2023

fix: small regression when parsing links for the account application #3235

Merged

		const customApplicationExplorer = getExplorer('custom-application-config');
		const customViewExplorer = getExplorer('custom-view-config');

		@@ -1,4 +1,5 @@
		const util = require('util');
		const { MessageChannel } = require('worker_threads');

		@@ -0,0 +1,107 @@
		import { type ReactNode, useEffect, useRef } from 'react';

		const customApplicationContext = useApplicationContext();
		const customViewContext = useCustomViewContext();

	initialProjectKey: 'almond-40',
	initialProjectKey: '${env:CTP_INITIAL_PROJECT_KEY}'

	Move component to application-shell package
	Move CustomViewLoader to application-shell package

Support Custom Views local development #3175

Support Custom Views local development #3175

Conversation

CarlosCortizasCT commented Aug 22, 2023 • edited by Rhotimee

Summary

Description

changeset-bot bot commented Aug 22, 2023 • edited

🦋 Changeset detected

github-actions bot commented Aug 30, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emmenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emmenko left a comment

Choose a reason for hiding this comment

Rhotimee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CarlosCortizasCT commented Aug 22, 2023 •

edited by Rhotimee

changeset-bot bot commented Aug 22, 2023 •

edited

github-actions bot commented Aug 30, 2023 •

edited