Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rebranding modal pop-up to announce visual changes #3516

Merged
merged 3 commits into from
May 9, 2024

Conversation

chloe0592
Copy link
Contributor

@chloe0592 chloe0592 commented May 8, 2024

We no longer need the modal that announced the rebranding changes in the MC.

PR that introduced the modal - here.

@chloe0592 chloe0592 self-assigned this May 8, 2024
@chloe0592 chloe0592 requested a review from a team as a code owner May 8, 2024 08:27
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 9:26am

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: f0fc659

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/application-shell Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/cypress Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/react-notifications Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. To be frank: I can't wait for this 😄. Let's not forget we can remove some local storage value setting from Cypress and Checkly as a follow-up of integrating this update. Just DM me if you need more information.

@chloe0592
Copy link
Contributor Author

Awesome. To be frank: I can't wait for this 😄. Let's not forget we can remove some local storage value setting from Cypress and Checkly as a follow-up of integrating this update. Just DM me if you need more information.

Thank you @tdeekens, for the reminder! I removed the local storage values from this repo here. And I'll create a follow-up ticket so we don't miss on removing it from other repos as well.

Copy link
Contributor

@kark kark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏾

@chloe0592 chloe0592 merged commit 179da9a into main May 9, 2024
18 checks passed
@chloe0592 chloe0592 deleted the SHIELD-1146-remove-rebranding-modal-pop-up branch May 9, 2024 07:18
@ct-changesets ct-changesets bot mentioned this pull request May 9, 2024
ddouglasz pushed a commit that referenced this pull request May 22, 2024
* chore: removing rebranding modal

* chore: remove local storage value for rebranding modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants