fix(loggers): catch errors when parsing loggers metadata #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e351638 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tdeekens
approved these changes
May 17, 2024
kark
approved these changes
May 17, 2024
namm2
reviewed
May 17, 2024
| ...(remoteAddress ? { remoteAddress } : {}), | ||
| }; | ||
| try { | ||
| const remoteAddress = req.socket?.remoteAddress; |
There was a problem hiding this comment.
Can we check the req.socket is not null first? I think the issue we got it because the socket isn't/wasn't success then there will be no remoteAddress as the result.
There was a problem hiding this comment.
Yes the ?. does the null check
emmenko
commented
May 17, 2024
| return { | ||
| clientIp: clientIp ?? remoteAddress, | ||
| proxyIps, | ||
| hostname: req.socket ? req.hostname : undefined, |
There was a problem hiding this comment.
We also added here an extra check for req.socket before accessing req.hostname
Merged
ddouglasz
pushed a commit
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.