Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DiscountCodeImporter] Show meaningful error #1832

Closed
VineetKumarKushwaha opened this issue Jan 31, 2023 · 0 comments · Fixed by #1833
Closed

[DiscountCodeImporter] Show meaningful error #1832

VineetKumarKushwaha opened this issue Jan 31, 2023 · 0 comments · Fixed by #1833

Comments

@VineetKumarKushwaha
Copy link
Collaborator

Support reference number

DiscountCodeImporter shows generic exception

  • ATM, if there is problem with input to discount-code-importer it throws an generic exception and doesn't tell us what is wrong and why it is failed.
  • This package is being used by the express-impex and hence the customers are not able to understand about the error and reach out to customer support to think its an bug.

Generic Error

  • image
    Currently user sees this exception incase of any error however specialy it should also show actual error like
    error: Cart Discount '0bfd0919-0540-4350-a6af-16ffa913a954' doesn't require a discount code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(discount-code-importer): improve error logging commercetools/nodejs
1 participant
@VineetKumarKushwaha