Merge pull request #118 from sphereio/refactor/status-codes

refactor(baseService): remove standard status code of 500
commercetools · Feb 29, 2016 · b475f5d · b475f5d
2 parents d537576 + d45d1e8
commit b475f5d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/coffee/services/base.coffee b/src/coffee/services/base.coffee
@@ -561,7 +561,7 @@ class BaseService
       else
         errorMessage = error
       errorResp =
-        statusCode: response?.statusCode or 500
+        statusCode: response?.statusCode
         message: errorMessage
         originalRequest: originalRequest
       errorResp.body = body if body

diff --git a/src/spec/client/services/base.spec.coffee b/src/spec/client/services/base.spec.coffee
@@ -249,7 +249,6 @@ describe 'Service', ->
           .then -> done('Should not happen')
           .catch (error) ->
             expect(error.body).toEqual
-              statusCode: 500
               message: 'timeout'
               originalRequest:
                 options:
@@ -555,7 +554,6 @@ describe 'Service', ->
           .catch (error) ->
             expect(error.name).toBe 'HttpError'
             expect(error.body).toEqual
-              statusCode: 500
               message: 'foo'
               originalRequest:
                 options: {}
@@ -601,7 +599,6 @@ describe 'Service', ->
             .catch (error) ->
               expect(error.name).toBe 'HttpError'
               expect(error.body).toEqual
-                statusCode: 500
                 message: 'foo'
                 originalRequest:
                   options: {}
@@ -661,7 +658,6 @@ describe 'Service', ->
             .catch (error) ->
               expect(error.name).toBe 'HttpError'
               expect(error.body).toEqual
-                statusCode: 500
                 message: 'foo'
                 originalRequest:
                   options: {}
@@ -758,7 +754,6 @@ describe 'Service', ->
             .catch (error) ->
               expect(error.name).toBe 'HttpError'
               expect(error.body).toEqual
-                statusCode: 500
                 message: 'foo'
                 originalRequest:
                   options: {}