Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gzip compression by default for all requests #196

Closed
mmoelli opened this issue Dec 21, 2016 · 2 comments · Fixed by #221
Closed

Support gzip compression by default for all requests #196

mmoelli opened this issue Dec 21, 2016 · 2 comments · Fixed by #221
Assignees
@wizzy25
Labels
Type: Enhancement

Comments

@mmoelli
Copy link
Contributor

mmoelli commented Dec 21, 2016 •
edited by wizzy25

Expected behavior

  • All requests should use gzip as default to improve performance

Actual behavior

  • At the moment, no requests sent via the node-sdk are using this, which leads to performance degradation

Steps to reproduce the behavior
@Siilwyn
Copy link
Contributor

Siilwyn commented Feb 10, 2017

@emmenko how does the new SDK handle this?

@emmenko
Copy link
Member

emmenko commented Feb 12, 2017

I haven't looked into it yet, I've opened a new issue commercetools/nodejs#79

For this sdk, since we're using request, it's just a matter of enabling it gzip: true.

@emmenko emmenko mentioned this issue Feb 28, 2017
Closed
@wizzy25 wizzy25 self-assigned this Mar 22, 2017
wizzy25 added a commit that referenced this issue Mar 22, 2017
@wizzy25
feat(gzip): allow gzip by default for all requests
e4a81e6 
fixed #196
@wizzy25 wizzy25 mentioned this issue Mar 22, 2017
Merged
wizzy25 added a commit that referenced this issue Mar 23, 2017
@wizzy25
feat(gzip): make gzip optional
805f476 
Allow option to disable gzip compression with a flag (gzipEnable: false)
gzip compression still remains enabled by default

fixes #196
hisabimbola pushed a commit that referenced this issue Mar 31, 2017
@wizzy25 @hisabimbola
feat(gzip): allow gzip by default for all requests (#221)
99f4f0c 
* feat(gzip): allow gzip by default for all requests

fixed #196

* feat(gzip): make gzip optional

Allow option to disable gzip compression with a flag (gzipEnable: false)
gzip compression still remains enabled by default

fixes #196

* docs(sphere-client): update online documentation

update documentation at http://sphereio.github.io/sphere-node-sdk/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wizzy25 wizzy25

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gzip): allow gzip by default for all requests commercetools/sphere-node-sdk
5 participants
@emmenko @mmoelli @Siilwyn @hisabimbola @wizzy25