fix(productSync): Update categories before categoryOrderHints #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnasa
suggested changes
Apr 5, 2017
There was a problem hiding this comment.
After a short discussion with @wizzy25 ,
I would rather see that the setCategoryHint is moved out of the actionMapsBase and that you create a separate mapper for this action, with the specified criteria (such as categories should be linked to the product) to fulfil the action
code
// in utils/product.coffee
const actionCategoryOrderHint = {
action: 'setCategoryOrderHint',
key: 'categoryOrderHints',
}
actionsMapCategoryOrderHint: () => {
const action = this.buildBaseAttributesAction(actionCategoryOrderHint, diff, old_obj)
// do your thing then push to the actions list!
}
// in product-sync.coffee
// below 'categories' mapper configuration
allActions.push(
this._mapActionOrNot(
'categoryOrderHint',
() => this._utils.actionsMapCategoryOrderHint(diff)
)
)Once you take this approach, make sure to remove the setCategoryHint from actionsBaseList, and you can move the categories action configuration back to it original order
…ions are generated
adnasa
approved these changes
Apr 6, 2017
wizzy25
approved these changes
Apr 7, 2017
|
@wizzy25 can you please merge this PR? I am not authorized to do that 😢 |
|
@emmenko Could you review (and merge?) this PR? I don't have write access on this repo |
hisabimbola
reviewed
Apr 21, 2017
| actions = Object.keys(action.categoryOrderHints) | ||
| .map (categoryId) -> | ||
| orderHint = action.categoryOrderHints[categoryId] | ||
| if orderHint is null or orderHint is undefined |
There was a problem hiding this comment.
in coffee this line is same as orderHint?
hisabimbola
approved these changes
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #218
Description
When generating product update actions category actions should be placed before categoryOrderHint actions so we can add product to category and create a categoryOrderHint in one request.
Todo