Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(customFileds): Add tests with exporting custom fields #56

Merged
merged 2 commits into from
Jun 12, 2017

Conversation

junajan
Copy link
Contributor

@junajan junajan commented Jun 7, 2017

Summary

Resolves #54

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation

@junajan junajan self-assigned this Jun 7, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.317% when pulling f9a08bb on 54-export-custom-fields-documentation into 3127a3f on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.317% when pulling f9a08bb on 54-export-custom-fields-documentation into 3127a3f on master.

README.md Outdated
@@ -65,6 +65,7 @@ The following headers can be used in the CSV template
- `lineItems.variant.*` - eg. `sku` or `images`
- `shippingAddress.*` - eg. `lastName` or `postalCode`
- `billingAddress.*`
- `custom.fields.*` - eg `custom.fields.fieldName` will export custom field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very minor nitpick: eg -> eg.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.317% when pulling 818cfad on 54-export-custom-fields-documentation into 3127a3f on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.317% when pulling 818cfad on 54-export-custom-fields-documentation into 3127a3f on master.

@junajan junajan merged commit 9e2c70a into master Jun 12, 2017
@junajan junajan deleted the 54-export-custom-fields-documentation branch June 12, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants