Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product-import): add check for empty results from CTP #164

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

lojzatran
Copy link
Contributor

Summary

In our projects, sometimes we get this the error message: "Unhandled rejection TypeError: Cannot read property '0' of undefined.

It could mean one of the 2 options:

  1. platform delivers empty response
  2. the sphere product import processes the response wrongly and didn’t add result.body

In this PR, I added more detailed logs so it's easier to investigate next time we got an error.

Copy link
Contributor

@daern91 daern91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇Thanks!

@butenkor
Copy link
Member

Hi @daern91 Could you please merge and release?

@daern91 daern91 merged commit db79674 into master Jul 19, 2019
@daern91 daern91 deleted the Fix/body-results-check branch July 19, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants